add multiple database support by allowing injection of a different AR base class #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… base class Closes ezcater#22.
agrobbin
force-pushed
the
multi-db-support-custom-base-class
branch
from
8303766
to
93885f6
Compare
jmpage
approved these changes
Mar 21, 2024
|
Thanks, and HI, @jmpage! |
|
Hi to you too, @agrobbin! |
|
@jmpage I saw there were some other changes that are unreleased (removing support for older versions of Ruby / AR), so I was curious if this will need to wait for other internal updates before it can be released as a new version. |
|
@agrobbin v3.0.0 is now available on rubygems.org |
|
Thanks @jmpage!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did we change?
Now, you can inject which base class you want to use when setting up the listener. It still defaults to
ActiveRecord::Base.Why are we doing this?
Multiple databases can be easily supported in recent versions of Rails / Active Record, and one way to do that is to have a different abstract Active Record base class with different connection configuration via
connected_to.Closes #22.
How was it tested?