fix(symlink): fix --dereference --sort=size #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoSal
force-pushed
the
fix_dereference_sort_size
branch
2 times, most recently
from
031ade9
to
b8a481e
Compare
gierens
previously approved these changes
Jul 9, 2024
cafkafk
reviewed
Oct 18, 2024
`File::length()` did not take `--dereference` into account, and used symlink metadata unconditionally. This commit fixes that. Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
MoSal
force-pushed
the
fix_dereference_sort_size
branch
from
a64de1a
to
f519bc6
Compare
|
@cafkafk Rebased. |
|
Hmm, seem the bsd tests are failing... I'm not sure this is your fault, it may just be github being weird >_> |
Looks like it was a temporary issue, but the previous runs timed out. eza/.github/workflows/unit-tests-bsd.yml Line 29 in e53a043 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File::length()did not take--dereferenceinto account, and usedsymlink metadata unconditionally.
This commit fixes that.