Skip to content

feat: Implement --hyperlink=auto #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
henryhchchc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Implement --hyperlink=auto #1664

henryhchchc wants to merge 1 commit into from
+51 −17

Conversation

@henryhchchc
Copy link

@henryhchchc henryhchchc commented Nov 6, 2025 •
edited
Loading

Implement --hyperlink=auto/always/never. This enables eza to embed hyperlinks only when printing to a terminal.

Fixes #1093
Fixes #703

sseering
sseering reviewed Nov 27, 2025
View reviewed changes
@henryhchchc henryhchchc requested a review from sseering November 28, 2025 01:44
@henryhchchc henryhchchc force-pushed the feat/hyperlink-when branch 2 times, most recently from 4710e58 to 4f8a98d Compare December 18, 2025 07:15
@henryhchchc
Copy link
Author

henryhchchc commented Dec 18, 2025 •
edited
Loading

The test is obsolete

Fixed by 58b98cf

Details ``` eza> Testing tests/gen/long_time_style_relative_nix.toml ... failed 16ms 475us 986ns

eza> ---- expected: stdout
eza> ++++ actual: stdout
eza> 1 - drwxr-xr-x - nixbld 55 years git
eza> 2 - drwxr-xr-x - nixbld 55 years grid
eza> 3 - drwxr-xr-x - nixbld 55 years group
eza> 4 - drwxr-xr-x - nixbld 55 years icons
eza> 5 - drwxr-xr-x - nixbld 55 years perms
eza> 6 - drwxr-xr-x - nixbld 55 years size
eza> 7 - drwxr-xr-x - nixbld 55 years specials
eza> 8 - drwxr-xr-x - nixbld 55 years symlinks
eza> 9 - drwxr-xr-x - nixbld 55 years time
eza> 1 + drwxr-xr-x - nixbld 56 years git
eza> 2 + drwxr-xr-x - nixbld 56 years grid
eza> 3 + drwxr-xr-x - nixbld 56 years group
eza> 4 + drwxr-xr-x - nixbld 56 years icons
eza> 5 + drwxr-xr-x - nixbld 56 years perms
eza> 6 + drwxr-xr-x - nixbld 56 years size
eza> 7 + drwxr-xr-x - nixbld 56 years specials
eza> 8 + drwxr-xr-x - nixbld 56 years symlinks
eza> 9 + drwxr-xr-x - nixbld 56 years time
eza> stderr:


</details>

@henryhchchc
Copy link
Author

henryhchchc commented Jan 7, 2026

I think the issues are addressed and the tests are passing now. Would appreciate your reviews! @sseering @MartinFillon @PThorpe92 @gierens @cafkafk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinFillon MartinFillon Awaiting requested review from MartinFillon MartinFillon is a code owner

@PThorpe92 PThorpe92 Awaiting requested review from PThorpe92 PThorpe92 is a code owner

@gierens gierens Awaiting requested review from gierens gierens is a code owner

@cafkafk cafkafk Awaiting requested review from cafkafk cafkafk is a code owner

@sseering sseering Awaiting requested review from sseering

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@henryhchchc @sseering