Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-Merge-Commit CI Job #1121

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

gierens
Copy link
Member

@gierens gierens commented Sep 5, 2024

This adds a CI job that fails if a PR branch contains merge commits.

Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@gierens
Copy link
Member Author

gierens commented Sep 5, 2024

Ok, CI runs through, I'm now gonna merge something to see if the CI jobs fails afterwards.

@gierens
Copy link
Member Author

gierens commented Sep 5, 2024

Jap, fails, seems to work!

Screenshot from 2024-09-05 12-27-58

@gierens
Copy link
Member Author

gierens commented Sep 5, 2024

Ok, I'm removing the test merge again.

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh neat, LGTM, let's put it in production and see how contributors react to it :p

@cafkafk cafkafk merged commit 0c91829 into eza-community:main Sep 6, 2024
4 checks passed
@cafkafk
Copy link
Member

cafkafk commented Sep 6, 2024

I did see this error https://github.com/eza-community/eza/actions/runs/10735513734

is this what the bb84f6b rename solves?

@gierens
Copy link
Member Author

gierens commented Sep 6, 2024

I did see this error https://github.com/eza-community/eza/actions/runs/10735513734

is this what the bb84f6b rename solves?

I simply renamed it, so the name reflects the now more general use of the workflow.

@gierens
Copy link
Member Author

gierens commented Sep 6, 2024

Maybe that was the error I intentionally produced to test this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants