fixBug: Conditional Stacked Functions in selecting#180
Merged
TheTechsTech merged 9 commits intoezSQL:masterfrom Feb 2, 2020
Merged
fixBug: Conditional Stacked Functions in selecting#180TheTechsTech merged 9 commits intoezSQL:masterfrom
TheTechsTech merged 9 commits intoezSQL:masterfrom
Conversation
Added the ability to set a $tableAs for joins if the left table is the same as the right table. Will default to the right table name if not set.
Fixed issue where the right table in $onCondition needed to match $tableAs if it was set.
Updated the examples for the different joins to reflect the new `$tableAs` variable in the functions
Missed a new line on the last commit. Also missed a param in the joining query description and some psr-2 changes. Also found an issue with $condition being used in $onCondition not being consistent.
Changed $condition back to `=` in first and last $onCondition as wasn't meant to be changed.
Update ezSQL for new fixes
To include `leftJoin()` phpunit testing and also fix a couple of phpunit depreciation warnings.
Contributor
Author
|
@techno-express ok, I finally got around to writing a phpunit test. Let me know if you're happy with this. It passes when I run it. 😄 |
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
============================================
+ Coverage 83.56% 84.91% +1.34%
- Complexity 788 793 +5
============================================
Files 14 14
Lines 2002 2002
============================================
+ Hits 1673 1700 +27
+ Misses 329 302 -27
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #174
Removed check for $columnFields being empty, and added dots between table and column names in the query builder.
Also, fixed a couple of phpunit depreciation warnings.