docs: Recommend .md extension for PRD files#1397
docs: Recommend .md extension for PRD files#1397Crunchyman-ralph merged 5 commits intoeyaltoledano:nextfrom
Conversation
|
|
Warning Rate limit exceeded@bjcoombs has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 27 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughTwo documentation files updated: assets/AGENTS.md changes PRD file extension references from .txt to .md with added formatting recommendations, and CLAUDE.md adds a changeset guideline for code changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cb5936e to
dd80b41
Compare
…d .md for PRDs This addresses two documentation improvements: 1. **Claude Code Configuration Behavior (eyaltoledano#1180)** - Added comprehensive section explaining how Task Master interacts with Claude Code's .claude configuration - Clarified that Task Master only passes MCP config when claudeCode.mcpServers is configured - Documented precedence: explicit Task Master config vs Claude CLI defaults - Provided practical examples for different configuration scenarios - Added recommendations for deterministic vs. existing-setup workflows 2. **PRD File Extension Recommendation** - Updated all examples to use .md extension instead of .txt for PRD files - Added prominent note explaining benefits of .md: syntax highlighting, proper rendering, better collaboration - Updated directory structure diagrams and workflow examples - Clarified that both extensions work, but .md is recommended for editor support Files modified: - docs/examples/claude-code-usage.md: Added "Claude Code Configuration Behavior" section - assets/AGENTS.md: Updated all PRD references to use .md, added PRD format note Resolves: eyaltoledano#1180
- Added changeset for documentation updates (patch) - Updated CLAUDE.md to require changesets for all PRs
dd80b41 to
f1b94b6
Compare
Crunchyman-ralph
left a comment
There was a problem hiding this comment.
lgtm, just please address my single comment, and if you want to go the extra mile, add the equivalent doc changes or add the missing docs on apps/docs please
There was a problem hiding this comment.
When we make improvements to the docs, we don't add it in the changeset since its not very user-facing or feature oriented, its just docs hehe.
Remove this file
|
If this PR is based on my old comments/analysis of how claude-code-sdk used to work, it may no longer be accurate and you guys will want to make sure documentation is written to how the newer claude-agent-sdk actually works. Anthropic's release of claude-agent-sdk was a breaking change and the significantly changed functionality (no default system prompt, new append system prompt, nothing loading from default cli unless settingSources is passed). I see the comment referenced was from Sep 3, but |
|
Looking at the package.json it looks like 1.1.4 is being used, so probably okay to base the documentation on the older comments, just be aware of the significant changes in future versions of |
Based on feedback from @ben-vargas: **Removed:** - Changeset file (not needed for docs-only PR) - Claude Code `.claude` configuration behavior documentation (will become stale when upgrading to ai-sdk-provider-claude-code v2.0.0+ which uses @anthropic-ai/claude-agent-sdk) **Updated:** - CLAUDE.md changeset guidelines: clarified changesets are only needed for code changes, not docs-only PRs **Kept:** - PRD file format recommendation: Updated all examples to use `.md` extension instead of `.txt` for better editor support, syntax highlighting, and rendering - Added note explaining benefits of `.md` format This keeps the PR focused on the non-controversial PRD format improvement and avoids documenting behavior that will soon change. Addresses feedback in: eyaltoledano#1180
Updates Based on FeedbackThanks for the review! I've simplified this PR based on the feedback: Removed
Updated
Kept
This keeps the PR focused on the non-controversial PRD format improvement. Ready for review! 🚀 |
Applied the same PRD format recommendations to the user-facing documentation site: - apps/docs/getting-started/quick-start/prd-quick.mdx: - Updated template references from .txt to .md - Added explanation of .md benefits in note box - Updated all command examples to use .md extension - Updated file naming examples - apps/docs/capabilities/rpg-method.mdx: - Updated RPG template reference to .md - Updated standard template reference to .md - Updated parse-prd command examples - Updated workflow examples Addresses @Crunchyman-ralph's request to update apps/docs
|
✅ @Crunchyman-ralph - Added the equivalent documentation updates to
All user-facing documentation now consistently recommends |
Renamed actual template files to match documentation updates: - .taskmaster/templates/example_prd.txt → example_prd.md - .taskmaster/templates/example_prd_rpg.txt → example_prd_rpg.md This ensures the actual files match what we're recommending in the documentation.
Crunchyman-ralph
left a comment
There was a problem hiding this comment.
sure, we can recommend .md
|
@bjcoombs we already upgraded to claude code 2.0 (its in the next branch, so make sure this PR reflects that |
|
@Crunchyman-ralph I reverted the summary of @ben-vargas earlier comments around claud api due to the upgrade, so this is just about .md files now.. I've updated the pr description to reflect that.. |
* docs: Clarify Claude Code .claude configuration behavior and recommend .md for PRDs This addresses two documentation improvements: 1. **Claude Code Configuration Behavior (eyaltoledano#1180)** - Added comprehensive section explaining how Task Master interacts with Claude Code's .claude configuration - Clarified that Task Master only passes MCP config when claudeCode.mcpServers is configured - Documented precedence: explicit Task Master config vs Claude CLI defaults - Provided practical examples for different configuration scenarios - Added recommendations for deterministic vs. existing-setup workflows 2. **PRD File Extension Recommendation** - Updated all examples to use .md extension instead of .txt for PRD files - Added prominent note explaining benefits of .md: syntax highlighting, proper rendering, better collaboration - Updated directory structure diagrams and workflow examples - Clarified that both extensions work, but .md is recommended for editor support Files modified: - docs/examples/claude-code-usage.md: Added "Claude Code Configuration Behavior" section - assets/AGENTS.md: Updated all PRD references to use .md, added PRD format note Resolves: eyaltoledano#1180 * chore: Add changeset and require changesets for PRs - Added changeset for documentation updates (patch) - Updated CLAUDE.md to require changesets for all PRs * docs: Simplify PR to only recommend .md extension for PRDs Based on feedback from @ben-vargas: **Removed:** - Changeset file (not needed for docs-only PR) - Claude Code `.claude` configuration behavior documentation (will become stale when upgrading to ai-sdk-provider-claude-code v2.0.0+ which uses @anthropic-ai/claude-agent-sdk) **Updated:** - CLAUDE.md changeset guidelines: clarified changesets are only needed for code changes, not docs-only PRs **Kept:** - PRD file format recommendation: Updated all examples to use `.md` extension instead of `.txt` for better editor support, syntax highlighting, and rendering - Added note explaining benefits of `.md` format This keeps the PR focused on the non-controversial PRD format improvement and avoids documenting behavior that will soon change. Addresses feedback in: eyaltoledano#1180 * docs: Update apps/docs to recommend .md extension for PRD files Applied the same PRD format recommendations to the user-facing documentation site: - apps/docs/getting-started/quick-start/prd-quick.mdx: - Updated template references from .txt to .md - Added explanation of .md benefits in note box - Updated all command examples to use .md extension - Updated file naming examples - apps/docs/capabilities/rpg-method.mdx: - Updated RPG template reference to .md - Updated standard template reference to .md - Updated parse-prd command examples - Updated workflow examples Addresses @Crunchyman-ralph's request to update apps/docs * refactor: Rename PRD template files from .txt to .md extension Renamed actual template files to match documentation updates: - .taskmaster/templates/example_prd.txt → example_prd.md - .taskmaster/templates/example_prd_rpg.txt → example_prd_rpg.md This ensures the actual files match what we're recommending in the documentation. --------- Co-authored-by: Ben Coombs <bjcoombs@users.noreply.github.com>
Summary
Updates documentation to recommend using
.md(Markdown) extension for PRD files instead of.txt, providing better developer experience through syntax highlighting and proper rendering in editors.Changes Made
PRD Format Recommendation (
assets/AGENTS.md).txtto.md:task-master parse-prd .taskmaster/docs/prd.md.mdformat:.mdis recommendedChangeset Guidelines (
CLAUDE.md)Why
.mdOver.txt?While both formats work with Task Master's
parse-prdcommand,.mdprovides:Related Issues
Related to discussion in #1180 (though this PR no longer addresses the
.claudeconfiguration question from that issue)Note: This PR originally included Claude Code
.claudeconfiguration documentation, but that was removed based on feedback that it would become stale when upgrading toai-sdk-provider-claude-codev2.0.0+.