Ralph/chore/update.from.main.0.31.0#1373
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ralph Khreish <35776126+Crunchyman-ralph@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 64785ea The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughPR transitions version 0.31.0 from pre-release to stable, removes pre-release changesets, adds ZAI Coding provider as a separate endpoint for subscription-based routing, and implements auto-restart functionality after CLI updates to use the new version immediately. Changes
Sequence DiagramsequenceDiagram
participant User
participant CLI
participant UpdateCheck
participant AutoUpdate
participant Restart
User->>CLI: Run task-master command
CLI->>UpdateCheck: Check for updates (before parse)
UpdateCheck-->>CLI: Update available & autoUpdate enabled
CLI->>AutoUpdate: performAutoUpdate()
AutoUpdate-->>CLI: Success with new version
CLI->>Restart: restartWithNewVersion(argv)
Restart->>Restart: Spawn new process with inherited stdio
Restart-->>User: New CLI process runs command
Restart->>CLI: Exit current process
Note over CLI,Restart: If no update available or update fails,<br/>continue with current version
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
packages/ai-sdk-provider-grok-cli/CHANGELOG.md (1)
1-11: Five consecutive duplicate "## null" headings violate MD024 linting and indicate changelog corruption.This changelog contains five identical "## null" section headings with no meaningful content between them. This violates the markdownlint MD024 rule (no-duplicate-heading) and indicates a serious issue with changeset generation or manual editing.
The file should contain at most one changelog entry per version. Please regenerate changelogs using:
npx changeset version --no-commitand verify the output before committing.
packages/tm-core/CHANGELOG.md (1)
3-14: Investigate multiple "## null" changelog entries.The changelog contains six "## null" headings (lines 3, 5, 7, 9, 11, 13), which suggests an issue with the changeset automation process where version numbers are not being properly resolved. This could indicate:
- Changesets not being consumed correctly during version bump
- Version determination failing during changelog generation
- Accumulated unresolved changelog entries from multiple releases
Please investigate the changelog generation process and ensure changesets are being properly consumed and version numbers are correctly determined.
scripts/modules/task-manager/models.js (1)
448-654: Handlezai-codingprovider hints
WhensetModelis called with the newzai-codingprovider hint, execution falls through to the default branch and throws “Invalid provider hint”, so the freshly added provider cannot be selected through the CLI/MCP flows. Add a branch mirroring the other provider cases that setsdeterminedProvider = CUSTOM_PROVIDERS.ZAI_CODING(and optionally reuses the internal model metadata for maxTokens) so the hint is accepted instead of blowing up.- } else { - // Invalid provider hint - should not happen with our constants - throw new Error(`Invalid provider hint received: ${providerHint}`); - } + } else if (providerHint === CUSTOM_PROVIDERS.ZAI_CODING) { + determinedProvider = CUSTOM_PROVIDERS.ZAI_CODING; + const zaiModelData = availableModels.find( + (m) => m.provider === CUSTOM_PROVIDERS.ZAI_CODING && m.id === modelId + ); + if (zaiModelData) { + modelData = zaiModelData; + report('info', `Setting Z.ai Coding model '${modelId}'.`); + } else { + warningMessage = `Warning: Z.ai Coding model '${modelId}' not found in supported models. Setting without validation.`; + report('warn', warningMessage); + } + } else { + // Invalid provider hint - should not happen with our constants + throw new Error(`Invalid provider hint received: ${providerHint}`); + }
| ## null | ||
|
|
||
| ### Patch Changes | ||
|
|
||
| - Updated dependencies []: | ||
| - @tm/core@null |
There was a problem hiding this comment.
🧩 Analysis chain
Malformed changelog with duplicate "## null" entries and invalid dependency versions.
The CHANGELOG.md contains duplicate "## null" sections with identical "Updated dependencies []: @tm/core@null" entries. Version strings should be concrete semantic versions (e.g., "0.31.1"), not "null". This pattern appears across multiple changelog files, suggesting a systematic issue with changeset generation.
Can you verify that the changeset generation process completed correctly? Consider running:
to inspect and potentially regenerate the changelogs with proper version strings. If this is intentional (e.g., pre-release artifact), please clarify in the PR description.
🏁 Script executed:
npx changeset version
npx changeset publish --dry-runLength of output: 329
🏁 Script executed:
#!/bin/bash
# Check CHANGELOG.md to see the full context
echo "=== apps/mcp/CHANGELOG.md ==="
cat apps/mcp/CHANGELOG.md | head -30
# Check if .changeset directory exists and list changesets
echo -e "\n=== .changeset directory ==="
ls -la .changeset/ 2>/dev/null | head -20
# List recent changeset files
echo -e "\n=== Recent changesets ==="
find .changeset -name "*.md" -type f 2>/dev/null | xargs cat 2>/dev/null | head -50
# Check apps/mcp package.json for version
echo -e "\n=== apps/mcp/package.json version ==="
grep -A2 '"version"' apps/mcp/package.json 2>/dev/null | head -5
# Check @tm/core package.json for version
echo -e "\n=== packages/tm-core/package.json version ==="
grep -A2 '"version"' packages/tm-core/package.json 2>/dev/null | head -5Length of output: 2537
🏁 Script executed:
#!/bin/bash
# Read the actual changeset files
echo "=== light-clowns-hope.md ==="
cat .changeset/light-clowns-hope.md
echo -e "\n=== polite-jokes-flash.md ==="
cat .changeset/polite-jokes-flash.md
# Check .changesetrc or config
echo -e "\n=== .changeset/config.json ==="
cat .changeset/config.json
# Check git status to see what was modified
echo -e "\n=== git diff apps/mcp/CHANGELOG.md (first 50 lines) ==="
git diff apps/mcp/CHANGELOG.md 2>/dev/null | head -50Length of output: 1305
🏁 Script executed:
#!/bin/bash
# Check if there are other CHANGELOG files with similar issues
echo "=== CHANGELOGs with 'null' ==="
find . -name "CHANGELOG.md" -type f ! -path "./node_modules/*" ! -path "./.git/*" \
-exec sh -c 'if grep -q "## null" "$1"; then echo "$1"; fi' _ {} \;
# Check git status of CHANGELOG files
echo -e "\n=== Git status of CHANGELOG.md files ==="
git status --porcelain 2>/dev/null | grep CHANGELOG
# Show full CHANGELOG.md to see all duplicates
echo -e "\n=== Full apps/mcp/CHANGELOG.md ==="
wc -l apps/mcp/CHANGELOG.md
cat apps/mcp/CHANGELOG.mdLength of output: 565
Fix corrupted CHANGELOGs: 6 files contain duplicate "## null" entries from improper changeset version handling.
This is a systematic issue affecting multiple packages:
apps/cli/CHANGELOG.mdapps/mcp/CHANGELOG.mdpackages/ai-sdk-provider-grok-cli/CHANGELOG.mdpackages/build-config/CHANGELOG.mdpackages/tm-bridge/CHANGELOG.mdpackages/tm-core/CHANGELOG.md
Each has duplicate "## null" sections with invalid @tm/core@null dependency entries. The root cause: packages with empty version strings ("version": "" in package.json) are not ignored by changesets, so the version command converts empty strings to "null" and creates entries on repeated runs.
Required action: Either add internal packages (@tm/mcp, @tm/core, etc.) to .changeset/config.json ignore list, or assign proper semantic versions. Then regenerate the CHANGELOGs by removing these files and re-running changeset version once.
🤖 Prompt for AI Agents
In apps/mcp/CHANGELOG.md around lines 17-22 there is a duplicated "## null"
entry and an invalid dependency line (`@tm/core@null`) caused by packages with
empty version strings being processed by changesets; fix it by (1) updating
.changeset/config.json to add the internal packages with empty versions (e.g.,
@tm/mcp, @tm/core, and other listed packages) to the "ignore" array OR set
proper semantic versions in their package.json files, (2) delete the corrupted
CHANGELOG.md files listed in the review (apps/cli, apps/mcp,
packages/ai-sdk-provider-grok-cli, packages/build-config, packages/tm-bridge,
packages/tm-core), and (3) re-run the changesets version command once to
regenerate clean changelogs.
| **How to use:** | ||
| 1. Download and install [LM Studio](https://lmstudio.ai/) | ||
| 2. Launch LM Studio and download a model (e.g., Llama 3.2, Mistral, Qwen) | ||
| 3. Optional: Add api key to mcp.json or .env (LMSTUDIO_API_KEY) | ||
| 4. Go to the "Local Server" tab and click "Start Server" |
There was a problem hiding this comment.
Capitalize “API key” for consistency.
Elsewhere you use “API key”. Align this line.
- 3. Optional: Add api key to mcp.json or .env (LMSTUDIO_API_KEY)
+ 3. Optional: Add API key to mcp.json or .env (LMSTUDIO_API_KEY)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| **How to use:** | |
| 1. Download and install [LM Studio](https://lmstudio.ai/) | |
| 2. Launch LM Studio and download a model (e.g., Llama 3.2, Mistral, Qwen) | |
| 3. Optional: Add api key to mcp.json or .env (LMSTUDIO_API_KEY) | |
| 4. Go to the "Local Server" tab and click "Start Server" | |
| **How to use:** | |
| 1. Download and install [LM Studio](https://lmstudio.ai/) | |
| 2. Launch LM Studio and download a model (e.g., Llama 3.2, Mistral, Qwen) | |
| 3. Optional: Add API key to mcp.json or .env (LMSTUDIO_API_KEY) | |
| 4. Go to the "Local Server" tab and click "Start Server" |
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 60 to 64, the phrase "api key" is not capitalized
consistently with the rest of the document; change "api key" to "API key" (e.g.,
"Optional: Add API key to mcp.json or .env (LMSTUDIO_API_KEY)") to match the
existing capitalization elsewhere.
| - [#1362](https://github.com/eyaltoledano/claude-task-master/pull/1362) [`3e70edf`](https://github.com/eyaltoledano/claude-task-master/commit/3e70edfa3a1f47bd8a6d2d2a30c20c72f5758b9b) Thanks [@Crunchyman-ralph](https://github.com/Crunchyman-ralph)! - Improve parse PRD schema for better llm model compatiblity | ||
| - Fixes #1353 | ||
|
|
There was a problem hiding this comment.
Typo: “compatiblity” → “compatibility”.
Fix spelling in the Patch Changes bullet.
- Improve parse PRD schema for better llm model compatiblity
+ Improve parse PRD schema for better LLM model compatibility📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - [#1362](https://github.com/eyaltoledano/claude-task-master/pull/1362) [`3e70edf`](https://github.com/eyaltoledano/claude-task-master/commit/3e70edfa3a1f47bd8a6d2d2a30c20c72f5758b9b) Thanks [@Crunchyman-ralph](https://github.com/Crunchyman-ralph)! - Improve parse PRD schema for better llm model compatiblity | |
| - Fixes #1353 | |
| - [#1362](https://github.com/eyaltoledano/claude-task-master/pull/1362) [`3e70edf`](https://github.com/eyaltoledano/claude-task-master/commit/3e70edfa3a1f47bd8a6d2d2a30c20c72f5758b9b) Thanks [@Crunchyman-ralph](https://github.com/Crunchyman-ralph)! - Improve parse PRD schema for better LLM model compatibility | |
| - Fixes #1353 |
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 79 to 81, the word “compatiblity” in the Patch
Changes bullet is misspelled; update it to “compatibility” so the line reads
“…Improve parse PRD schema for better llm model compatibility”. Ensure only the
spelling is corrected and punctuation/formatting of the bullet remains
unchanged.
| ## 0.0.3 | ||
|
|
||
| ## 0.0.3 |
There was a problem hiding this comment.
Remove duplicate "## 0.0.3" changelog entry.
The changelog contains "## 0.0.3" twice (lines 5 and 7). Deduplicate to keep only one entry.
Apply this diff to remove the duplicate:
## 0.0.4
## 0.0.3
-
-## 0.0.3
## 0.0.2📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## 0.0.3 | |
| ## 0.0.3 | |
| ## 0.0.4 | |
| ## 0.0.3 | |
| ## 0.0.2 |
🧰 Tools
🪛 LanguageTool
[grammar] ~5-~5: Hier könnte ein Fehler sein.
Context: ...m/claude-code-plugin ## 0.0.4 ## 0.0.3 ## 0.0.3 ## 0.0.2
(QB_NEW_DE)
[grammar] ~7-~7: Hier könnte ein Fehler sein.
Context: ...ode-plugin ## 0.0.4 ## 0.0.3 ## 0.0.3 ## 0.0.2
(QB_NEW_DE)
🤖 Prompt for AI Agents
In packages/claude-code-plugin/CHANGELOG.md around lines 5 to 7, there is a
duplicated "## 0.0.3" header; remove the extra duplicate so the changelog
contains only a single "## 0.0.3" entry and adjust surrounding blank lines if
needed to keep consistent formatting.
| ## null | ||
|
|
||
| ### Patch Changes | ||
|
|
||
| - Updated dependencies []: | ||
| - @tm/core@null |
There was a problem hiding this comment.
Remove duplicate "## null" Patch Changes block.
The changelog has two identical "## null" sections with the same "Updated dependencies [@tm/core@null]" content. Keep only one entry and remove the duplicate.
Apply this diff to consolidate:
## null
### Patch Changes
- Updated dependencies []:
- @tm/core@null
-
-## null
-
-### Patch Changes
-
-- Updated dependencies []:
- - @tm/core@nullCommittable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
10-10: Multiple headings with the same content
(MD024, no-duplicate-heading)
🤖 Prompt for AI Agents
packages/tm-bridge/CHANGELOG.md lines 10-15: there are duplicate "## null" Patch
Changes sections both listing "Updated dependencies []: - @tm/core@null"; remove
the duplicate block so only one "## null" section remains, ensuring surrounding
headings and spacing remain consistent and that no other content is lost or
reordered.
1 participant
What type of PR is this?
Description
Related Issues
How to Test This
# Example commands or stepsExpected result:
Contributor Checklist
npm run changesetnpm testnpm run format-check(ornpm run formatto fix)Changelog Entry
For Maintainers
Summary by CodeRabbit
New Features
Chores