Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ralph Khreish <35776126+Crunchyman-ralph@users.noreply.github.com>
|
WalkthroughThis PR finalizes a release by removing multiple .changeset entries and the pre-release config, updating package versions from RC to stable, and adding/updating changelog entries across the repo (root, apps, and packages). No runtime code changes; all edits are documentation and metadata. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
packages/tm-core/CHANGELOG.md (1)
3-8: Broken changelog sections: duplicate “## null” headersMultiple “## null” headings violate MD024 and indicate a malformed release entry. Please remove these placeholders or regenerate via Changesets so only valid versions appear.
Apply to remove the null sections:
-## null - -## null - -## nullapps/docs/package.json (1)
3-9: Version bump OK; add required test scripts per guidelinesVersion 0.0.6 looks fine. This package.json lacks the standard test scripts required by our guidelines (test, test:watch, test:coverage, test:unit, test:integration, test:e2e, test:ci).
Add minimal no-op scripts to satisfy CI until real tests exist:
"scripts": { "dev": "mintlify dev", - "preview": "mintlify preview" + "preview": "mintlify preview", + "test": "echo \"No tests for docs yet\" && exit 0", + "test:watch": "npm run test", + "test:coverage": "npm run test", + "test:unit": "npm run test", + "test:integration": "npm run test", + "test:e2e": "npm run test", + "test:ci": "npm run test" },As per coding guidelines
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (19)
.changeset/auto-update-changelog-highlights.md(0 hunks).changeset/mean-planes-wave.md(0 hunks).changeset/nice-ways-hope.md(0 hunks).changeset/plain-falcons-serve.md(0 hunks).changeset/pre.json(0 hunks).changeset/silent-bushes-grow.md(0 hunks).changeset/smart-owls-relax.md(0 hunks)CHANGELOG.md(1 hunks)apps/cli/CHANGELOG.md(1 hunks)apps/docs/CHANGELOG.md(1 hunks)apps/docs/package.json(1 hunks)apps/extension/CHANGELOG.md(1 hunks)apps/extension/package.json(1 hunks)package.json(1 hunks)packages/ai-sdk-provider-grok-cli/CHANGELOG.md(1 hunks)packages/build-config/CHANGELOG.md(1 hunks)packages/claude-code-plugin/CHANGELOG.md(1 hunks)packages/claude-code-plugin/package.json(1 hunks)packages/tm-core/CHANGELOG.md(1 hunks)
💤 Files with no reviewable changes (7)
- .changeset/nice-ways-hope.md
- .changeset/smart-owls-relax.md
- .changeset/mean-planes-wave.md
- .changeset/pre.json
- .changeset/silent-bushes-grow.md
- .changeset/auto-update-changelog-highlights.md
- .changeset/plain-falcons-serve.md
🧰 Additional context used
📓 Path-based instructions (1)
package.json
📄 CodeRabbit inference engine (.cursor/rules/test_workflow.mdc)
Add and update test scripts in package.json to include test, test:watch, test:coverage, test:unit, test:integration, test:e2e, and test:ci
Files:
package.json
🧠 Learnings (4)
📓 Common learnings
Learnt from: Crunchyman-ralph
PR: eyaltoledano/claude-task-master#1232
File: packages/build-config/package.json:14-15
Timestamp: 2025-09-22T19:45:13.323Z
Learning: In the eyaltoledano/claude-task-master repository, Crunchyman-ralph intentionally omits version fields from internal packages (like tm/build-config) to prevent changesets from releasing new versions for these packages. This is the desired behavior for internal tooling packages that should not be published or versioned independently.
Learnt from: Crunchyman-ralph
PR: eyaltoledano/claude-task-master#1232
File: packages/tm-core/package.json:50-51
Timestamp: 2025-09-22T19:45:04.337Z
Learning: In the eyaltoledano/claude-task-master project, Crunchyman-ralph intentionally omits version fields from internal/private packages in package.json files to prevent changesets from releasing new versions of these packages while still allowing them to be processed for dependency updates. The changesets warnings about missing versions are acceptable as they don't break the process and achieve the desired behavior of only releasing public packages.
📚 Learning: 2025-09-26T19:03:33.225Z
Learnt from: Crunchyman-ralph
PR: eyaltoledano/claude-task-master#1252
File: package.json:130-132
Timestamp: 2025-09-26T19:03:33.225Z
Learning: In the eyaltoledano/claude-task-master repository, all packages with tm prefix are internal packages that are part of the monorepo structure and are not published externally.
Applied to files:
packages/claude-code-plugin/package.json
📚 Learning: 2025-09-26T19:05:47.555Z
Learnt from: Crunchyman-ralph
PR: eyaltoledano/claude-task-master#1252
File: packages/ai-sdk-provider-grok-cli/package.json:11-13
Timestamp: 2025-09-26T19:05:47.555Z
Learning: In the eyaltoledano/claude-task-master repository, internal tm/ packages use a specific export pattern where the "exports" field points to TypeScript source files (./src/index.ts) while "main" points to compiled output (./dist/index.js) and "types" points to source files (./src/index.ts). This pattern is used consistently across internal packages like tm/core and tm/ai-sdk-provider-grok-cli because they are consumed directly during build-time bundling with tsdown rather than being published as separate packages.
Applied to files:
packages/claude-code-plugin/package.json
📚 Learning: 2025-09-22T19:45:13.323Z
Learnt from: Crunchyman-ralph
PR: eyaltoledano/claude-task-master#1232
File: packages/build-config/package.json:14-15
Timestamp: 2025-09-22T19:45:13.323Z
Learning: In the eyaltoledano/claude-task-master repository, Crunchyman-ralph intentionally omits version fields from internal packages (like tm/build-config) to prevent changesets from releasing new versions for these packages. This is the desired behavior for internal tooling packages that should not be published or versioned independently.
Applied to files:
packages/claude-code-plugin/package.json
🪛 LanguageTool
apps/extension/CHANGELOG.md
[grammar] ~3-~3: Use correct spacing
Context: # Change Log ## 0.25.6 ## 0.25.6-rc.0 ### Patch Changes - Update...
(QB_NEW_EN_OTHER_ERROR_IDS_5)
packages/claude-code-plugin/CHANGELOG.md
[grammar] ~1-~1: Hier könnte ein Fehler sein.
Context: # @tm/claude-code-plugin ## 0.0.2
(QB_NEW_DE)
[grammar] ~3-~3: Hier könnte ein Fehler sein.
Context: # @tm/claude-code-plugin ## 0.0.2
(QB_NEW_DE)
packages/build-config/CHANGELOG.md
[grammar] ~7-~7: Hier könnte ein Fehler sein.
Context: .../build-config ## null ## null ## null ## 1.0.1
(QB_NEW_DE)
apps/docs/CHANGELOG.md
[grammar] ~3-~3: Hier könnte ein Fehler sein.
Context: # docs ## 0.0.6 ## 0.0.5 ## 0.0.4 ## 0.0.3 ## 0.0.2 ## ...
(QB_NEW_DE)
packages/tm-core/CHANGELOG.md
[grammar] ~7-~7: Use correct spacing
Context: # Changelog ## null ## null ## null ## 0.26.1 All notable changes to the @task...
(QB_NEW_EN_OTHER_ERROR_IDS_5)
🪛 markdownlint-cli2 (0.18.1)
packages/build-config/CHANGELOG.md
7-7: Multiple headings with the same content
(MD024, no-duplicate-heading)
packages/ai-sdk-provider-grok-cli/CHANGELOG.md
5-5: Multiple headings with the same content
(MD024, no-duplicate-heading)
CHANGELOG.md
29-29: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
packages/tm-core/CHANGELOG.md
7-7: Multiple headings with the same content
(MD024, no-duplicate-heading)
apps/cli/CHANGELOG.md
17-17: Multiple headings with the same content
(MD024, no-duplicate-heading)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Test
- GitHub Check: typecheck
- GitHub Check: build
🔇 Additional comments (4)
package.json (1)
3-27: LGTM: release to 0.29.0 and test scripts presentStable version finalized. All required test scripts are present and consistent with guidelines.
packages/claude-code-plugin/package.json (1)
3-3: Version bump looks good.Matches the release and changelog. No further action.
packages/claude-code-plugin/CHANGELOG.md (1)
1-3: Changelog entry added.Entry exists and aligns with 0.0.2 bump.
apps/extension/package.json (1)
6-6: RC → stable version bump looks correct.Confirm apps/extension/CHANGELOG.md has a 0.25.6 entry and that the release pipeline (vsce) will publish this version.
| - Updated dependencies []: | ||
| - @tm/core@null | ||
|
|
||
| ## null | ||
|
|
||
| ### Patch Changes | ||
|
|
There was a problem hiding this comment.
Malformed entries: duplicate “## null” blocks and “@tm/core@null”
Repeated null sections and dependency lines with “@tm/core@null” indicate broken generation. While @tm/core may intentionally omit a version (acceptable), the changelog shouldn’t show “null”. Please collapse or remove these placeholders and regenerate.
-### Patch Changes
-
-- Updated dependencies []:
- - @tm/core@null
-
-## null
-
-### Patch Changes
-
-- Updated dependencies []:
- - @tm/core@null
+### Patch Changes
+// (remove duplicate null sections or replace with the correct version)If keeping @tm/core private/unversioned, consider filtering it from dependency notes to avoid “null” leaking into published docs. Based on learnings
Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
17-17: Multiple headings with the same content
(MD024, no-duplicate-heading)
🤖 Prompt for AI Agents
In apps/cli/CHANGELOG.md around lines 14 to 20, there are malformed entries:
duplicate "## null" sections and a dependency line showing "@tm/core@null".
Remove the duplicate/null sections (collapse them into the appropriate release
section or delete placeholders), filter out or skip dependencies that have no
version (like @tm/core) when generating dependency notes (or show a clear label
such as "private/unversioned" instead of "null"), then regenerate the changelog
so no "null" placeholders remain in the published file.
| ## 0.0.6 | ||
|
|
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
LGTM: new 0.0.6 entry aligns with package.json
Consider adding a short note if this is a version-only bump for transparency.
🧰 Tools
🪛 LanguageTool
[grammar] ~3-~3: Hier könnte ein Fehler sein.
Context: # docs ## 0.0.6 ## 0.0.5 ## 0.0.4 ## 0.0.3 ## 0.0.2 ## ...
(QB_NEW_DE)
🤖 Prompt for AI Agents
In apps/docs/CHANGELOG.md around lines 3 to 4, the changelog currently only
lists "## 0.0.6" with no description; add a short sentence under the version
heading indicating this is a version-only bump (e.g., "Version-only bump to
align with package.json") or a brief summary of changes if any, to improve
transparency for readers.
| ## 0.25.6 | ||
|
|
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
LGTM: stable header added
Adding 0.25.6 above the RC is correct for finalizing. Consider adding a brief “No changes, promote RC to stable” line for clarity.
🧰 Tools
🪛 LanguageTool
[grammar] ~3-~3: Use correct spacing
Context: # Change Log ## 0.25.6 ## 0.25.6-rc.0 ### Patch Changes - Update...
(QB_NEW_EN_OTHER_ERROR_IDS_5)
🤖 Prompt for AI Agents
In apps/extension/CHANGELOG.md around lines 3 to 4, the new stable header "##
0.25.6" was added but lacks a brief explanatory line; insert a single line
immediately beneath the header such as "No changes; promoted RC to stable." (or
similar concise phrasing) to clarify this is a promotion of the RC rather than
new changes.
| - **49 slash commands** with clean naming (`/taskmaster:command-name`) | ||
| - **3 specialized AI agents** (task-orchestrator, task-executor, task-checker) | ||
| - **MCP server integration** for deep Claude Code integration | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
Inconsistent slash command namespace in docs.
You use both /taskmaster:command-name and /task-master-ai:command-name. Pick one and standardize across entries.
Also applies to: 107-109
🏁 Script executed:
#!/bin/bash
rg -n "task-master-ai" -n CHANGELOG.md
rg -n "/taskmaster:" -n CHANGELOG.mdLength of output: 1060
Standardize slash command namespace in CHANGELOG.md
Entries use /taskmaster:command-name (line 18) and /task-master-ai:command-name (line 107); pick one convention and update all occurrences to match.
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 18-21 (and also line 107), the slash command
namespace is inconsistent; standardize all occurrences to use the single
convention "/taskmaster:command-name" by searching the file for
"/task-master-ai:" and any other variants and replacing them with "/taskmaster:"
everywhere, updating examples and inline mentions to preserve punctuation and
formatting.
| ### The `rules add claude` command no longer copies commands and agents to `.claude/commands/` and `.claude/agents/`. Instead, it now | ||
| - Shows plugin installation instructions | ||
| - Only manages CLAUDE.md imports for agent instructions |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
Fix markdownlint MD022 (blank lines around headings).
Insert a blank line after the heading.
-### The `rules add claude` command no longer copies commands and agents to `.claude/commands/` and `.claude/agents/`. Instead, it now
+### The `rules add claude` command no longer copies commands and agents to `.claude/commands/` and `.claude/agents/`. Instead, it now
+
- Shows plugin installation instructionsCommittable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
29-29: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 29 to 31, the heading "The `rules add claude`
command no longer copies..." lacks a blank line beneath it which violates
markdownlint MD022; add a single blank line immediately after the heading line
so the following bullet list is separated from the heading.
| ## null | ||
|
|
||
| ## null |
There was a problem hiding this comment.
Duplicate “## null” entries
Two consecutive “## null” headings suggest a generation bug and trip MD024. Remove them or replace with a real version header after rerunning the release step.
-## null
-
-## null📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## null | |
| ## null |
🧰 Tools
🪛 LanguageTool
[grammar] ~3-~3: Use correct spacing
Context: # @tm/ai-sdk-provider-grok-cli ## null ## null
(QB_NEW_EN_OTHER_ERROR_IDS_5)
🪛 markdownlint-cli2 (0.18.1)
5-5: Multiple headings with the same content
(MD024, no-duplicate-heading)
🤖 Prompt for AI Agents
In packages/ai-sdk-provider-grok-cli/CHANGELOG.md around lines 3 to 5 there are
two consecutive "## null" headings (duplicate/placeholder entries). Remove the
duplicate "## null" lines or replace them with the correct version header
produced by rerunning the release step so the file contains a single valid
changelog heading (e.g., a proper "## x.y.z - YYYY-MM-DD") and re-run the
release generation to prevent regression.
| ## null | ||
|
|
There was a problem hiding this comment.
Extraneous “## null” heading
An additional “## null” block was introduced and duplicates prior ones. Clean it up to avoid broken changelog structure.
-## nullNote: internal @tm/* packages intentionally omit versions; still, changelogs shouldn’t contain “null” sections. Based on learnings
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## null |
🧰 Tools
🪛 LanguageTool
[grammar] ~7-~7: Hier könnte ein Fehler sein.
Context: .../build-config ## null ## null ## null ## 1.0.1
(QB_NEW_DE)
🪛 markdownlint-cli2 (0.18.1)
7-7: Multiple headings with the same content
(MD024, no-duplicate-heading)
🤖 Prompt for AI Agents
In packages/build-config/CHANGELOG.md around lines 7-8 there is an extraneous
"## null" heading that duplicates prior sections and breaks the changelog
structure; remove that "## null" heading (and any empty/null section beneath
it), verify there are no other "## null" occurrences in the file, and ensure
headings follow the expected "## [version]" or release-note format (if this was
produced by a generation script, update the generator/template to avoid emitting
"null" for omitted versions).
…date.from.main.october
1 participant
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ralph Khreish 35776126+Crunchyman-ralph@users.noreply.github.com
What type of PR is this?
Description
Related Issues
How to Test This
# Example commands or stepsExpected result:
Contributor Checklist
npm run changesetnpm testnpm run format-check(ornpm run formatto fix)Changelog Entry
For Maintainers
Summary by CodeRabbit
Documentation
Chores