Skip to content

Ralph/chore/fix.export.url#1288

Merged
Crunchyman-ralph merged 1 commit intonextfrom
ralph/chore/fix.export.url
Oct 13, 2025
Merged

Ralph/chore/fix.export.url#1288
Crunchyman-ralph merged 1 commit intonextfrom
ralph/chore/fix.export.url

Conversation

@Crunchyman-ralph
Copy link
Collaborator

@Crunchyman-ralph Crunchyman-ralph commented Oct 9, 2025

What type of PR is this?

  • 🐛 Bug fix
  • ✨ Feature
  • 🔌 Integration
  • 📝 Docs
  • 🧹 Refactor
  • Other:

Description

Related Issues

How to Test This

# Example commands or steps

Expected result:

Contributor Checklist

  • Created changeset: npm run changeset
  • Tests pass: npm test
  • Format check passes: npm run format-check (or npm run format to fix)
  • Addressed CodeRabbit comments (if any)
  • Linked related issues (if any)
  • Manually tested the changes

Changelog Entry


For Maintainers

  • PR title follows conventional commits
  • Target branch correct
  • Labels added
  • Milestone assigned (if applicable)

Summary by CodeRabbit

  • Chores
    • Updated bulk export API endpoint from /ai/api/v1/briefs/{briefId}/tasks/bulk to /ai/api/v1/briefs/{briefId}/tasks.
    • Adjusted request body schema: accountId now appears after the options block; source, options, and tasks remain unchanged.
    • No other externally visible interfaces were affected.

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2025

⚠️ No Changeset found

Latest commit: 9f4af71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 9, 2025

Walkthrough

Updated export service to call a different bulk export endpoint and adjusted the request payload structure by moving accountId after options. No exported signatures changed.

Changes

Cohort / File(s) Summary
Export service API path and payload update
packages/tm-core/src/services/export.service.ts
Changed endpoint from /ai/api/v1/briefs/${briefId}/tasks/bulk to /ai/api/v1/briefs/${briefId}/tasks; reordered request body to place accountId after options; retained other payload fields and structures; no public/exported signatures modified.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant C as Client
  participant ES as ExportService
  participant API as AI API

  C->>ES: exportTasks(briefId, source, options, tasks, accountId)
  note over ES: Prepare request payload<br/>- source, options, tasks<br/>- accountId (moved after options)
  ES->>API: POST /ai/api/v1/briefs/{briefId}/tasks<br/>Body: { source, options, accountId, tasks }
  API-->>ES: 200 OK / Error
  ES-->>C: Result/Exception

  rect rgba(230,245,255,0.5)
  note right of ES: Changed endpoint path (removed /bulk)
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • eyaltoledano

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The provided title “Ralph/chore/fix.export.url” appears to be a branch or task identifier rather than a concise, single-sentence summary of the main change, and it does not clearly convey that the bulk export API endpoint URL was updated. Because it does not highlight the key modification in a readable format, it does not meet the criteria for a clear and specific pull request title. Please update the PR title to a clear, concise sentence that summarizes the primary change, for example “Fix bulk export API endpoint URL in export service.”
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ralph/chore/fix.export.url

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aaf903f and 9f4af71.

📒 Files selected for processing (1)
  • packages/tm-core/src/services/export.service.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Test
🔇 Additional comments (2)
packages/tm-core/src/services/export.service.ts (2)

371-379: Clarify why accountId was moved after options.

The request body was reordered so that accountId now appears after options. Since JSON objects are unordered by spec, confirm whether:

  1. Your API schema (OpenAPI/Swagger/JSON-schema) enforces property order
  2. This change was made to address a validation error or documented requirement
  3. You can revert to the previous order if there’s no functional impact

365-365: Verify removal of the old bulk endpoint and readiness of the new one
Manually confirm there are no remaining references to /ai/api/v1/briefs/${briefId}/tasks/bulk in code, tests, or documentation, and ensure the replacement /ai/api/v1/briefs/${briefId}/tasks endpoint is live, supports the expected payload, and is deployed across all environments.


Comment @coderabbitai help to get the list of available commands and usage tips.

@Crunchyman-ralph Crunchyman-ralph merged commit 11b7354 into next Oct 13, 2025
6 checks passed
sfc-gh-dflippo pushed a commit to sfc-gh-dflippo/task-master-ai that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant