Skip to content

chore: adjust CI to run on all PRs#1244

Merged
Crunchyman-ralph merged 1 commit intonextfrom
ralph/chore/adjust.ci.to.run.on.all.prs
Sep 24, 2025
Merged

chore: adjust CI to run on all PRs#1244
Crunchyman-ralph merged 1 commit intonextfrom
ralph/chore/adjust.ci.to.run.on.all.prs

Conversation

@Crunchyman-ralph
Copy link
Collaborator

@Crunchyman-ralph Crunchyman-ralph commented Sep 24, 2025

What type of PR is this?

  • 🐛 Bug fix
  • ✨ Feature
  • 🔌 Integration
  • 📝 Docs
  • 🧹 Refactor
  • Other:

Description

Related Issues

How to Test This

# Example commands or steps

Expected result:

Contributor Checklist

  • Created changeset: npm run changeset
  • Tests pass: npm test
  • Format check passes: npm run format-check (or npm run format to fix)
  • Addressed CodeRabbit comments (if any)
  • Linked related issues (if any)
  • Manually tested the changes

Changelog Entry


For Maintainers

  • PR title follows conventional commits
  • Target branch correct
  • Labels added
  • Milestone assigned (if applicable)

Summary by CodeRabbit

  • Chores
    • CI now runs on all pull requests, providing consistent automated checks for every contribution.
    • Helps catch issues earlier and delivers clearer build/test status on each PR.
    • Improves reliability and contributor experience without changing user-facing functionality.

@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2025

⚠️ No Changeset found

Latest commit: 111e69a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 24, 2025

Walkthrough

The CI workflow's pull_request trigger was broadened by removing the branches filter, so it runs for all pull requests instead of only those targeting specific branches. No other workflow logic changes were introduced.

Changes

Cohort / File(s) Summary
CI workflow trigger
.github/workflows/ci.yml
Removed pull_request.branches filter; CI now triggers on all PRs rather than being restricted to specific branches.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as Developer
  participant GH as GitHub
  participant CI as CI Workflow

  rect rgb(240,248,255)
  note over GH,CI: Previous behavior (filtered)
  Dev->>GH: Open/Update PR (branch not in filter)
  GH--xCI: pull_request event not matched
  end

  rect rgb(235,255,235)
  note over GH,CI: New behavior (unfiltered)
  Dev->>GH: Open/Update PR (any branch)
  GH-->>CI: Trigger CI on pull_request
  CI->>CI: Run jobs as defined
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Suggested reviewers

  • eyaltoledano

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately describes the primary change—modifying the CI configuration so it runs on all pull requests—using clear conventional commit phrasing without extraneous details.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ralph/chore/adjust.ci.to.run.on.all.prs

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 35ba703 and 111e69a.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yml

Comment @coderabbitai help to get the list of available commands and usage tips.

@Crunchyman-ralph Crunchyman-ralph force-pushed the ralph/chore/adjust.ci.to.run.on.all.prs branch from 35ba703 to 111e69a Compare September 24, 2025 18:14
@Crunchyman-ralph Crunchyman-ralph merged commit 814265c into next Sep 24, 2025
6 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Nov 16, 2025
16 tasks
sfc-gh-dflippo pushed a commit to sfc-gh-dflippo/task-master-ai that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant