chore: improve pre-release CI to just use dropdown#1080
Merged
Crunchyman-ralph merged 2 commits intonextfrom Aug 3, 2025
Merged
chore: improve pre-release CI to just use dropdown#1080Crunchyman-ralph merged 2 commits intonextfrom
Crunchyman-ralph merged 2 commits intonextfrom
Conversation
|
Contributor
WalkthroughThe workflow configuration for the pre-release process was updated to remove the manual Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHub Actions
participant Repository
User->>GitHub Actions: Trigger pre-release workflow (workflow_dispatch or push)
GitHub Actions->>Repository: Checkout code at github.ref
GitHub Actions->>GitHub Actions: Run workflow steps
GitHub Actions->>Repository: Push changes to branch github.ref_name (if applicable)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (6)📓 Common learnings📚 Learning: document breaking changes...Applied to files:
📚 Learning: applies to scripts/modules/task-manager.js : extract tasks from prd documents using ai, create them ...Applied to files:
📚 Learning: applies to scripts/modules/* : all commands must resolve the tag using the pattern: options.tag || g...Applied to files:
📚 Learning: applies to scripts/modules/* : do not hard-code tag resolution (e.g., const tag = options.tag || 'ma...Applied to files:
📚 Learning: for changeset files (.changeset/*.md), crunchyman-ralph prefers to ignore formatting nitpicks about ...Applied to files:
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Crunchyman-ralph
changed the title
Collaborator
Author
|
@CodeRabbit please review again |
Contributor
|
@Crunchyman-ralph I'll conduct a comprehensive review of your PR #1080 "Chore/improve.release.ci.p2". This appears to be a substantial improvement covering CI/CD workflows, AI provider enhancements, and MCP tool fixes. 🧠 Learnings used✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/pre-release.yml(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/git_workflow.mdc:0-0
Timestamp: 2025-07-18T17:10:31.810Z
Learning: Pull Request descriptions must use the provided template, including Task Overview, Subtasks Completed, Implementation Details, Testing, Breaking Changes, and Related Tasks
Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/self_improve.mdc:0-0
Timestamp: 2025-07-18T17:13:11.229Z
Learning: Monitor code review comments for continuous improvement
Learnt from: Crunchyman-ralph
PR: eyaltoledano/claude-task-master#1069
File: .changeset/fix-tag-complexity-detection.md:0-0
Timestamp: 2025-08-02T15:33:22.656Z
Learning: For changeset files (.changeset/*.md), Crunchyman-ralph prefers to ignore formatting nitpicks about blank lines between frontmatter and descriptions, as he doesn't mind having them and wants to avoid such comments in future reviews.
Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/git_workflow.mdc:0-0
Timestamp: 2025-07-18T17:10:31.810Z
Learning: Pull Request titles must follow the format: Task <ID>: <Task Title>
Learnt from: eyaltoledano
PR: eyaltoledano/claude-task-master#1069
File: .changeset/floppy-news-buy.md:7-38
Timestamp: 2025-08-02T14:54:52.216Z
Learning: For major feature additions like new CLI commands, eyaltoledano prefers detailed changesets with comprehensive descriptions, usage examples, and feature explanations rather than minimal single-line summaries.
Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: assets/.windsurfrules:0-0
Timestamp: 2025-07-18T17:19:27.365Z
Learning: Monitor code review comments, track common development questions, update rules after major refactors, add links to relevant documentation, and cross-reference related rules.
Learnt from: Crunchyman-ralph
PR: eyaltoledano/claude-task-master#992
File: .coderabbit.yaml:1-169
Timestamp: 2025-07-16T16:06:07.169Z
Learning: CodeRabbit configuration files like .coderabbit.yaml are internal development tooling that affect the review process but don't impact end users, so changesets are not required for these configuration additions.
Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/changeset.mdc:0-0
Timestamp: 2025-07-18T17:07:53.100Z
Learning: Every pull request containing new features, bug fixes, breaking changes, performance improvements, significant refactoring, user-facing documentation updates, dependency updates, or impactful build/tooling changes should include a changeset file.
📚 Learning: document breaking changes...
Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/self_improve.mdc:0-0
Timestamp: 2025-07-18T17:13:11.229Z
Learning: Document breaking changes
Applied to files:
.github/workflows/pre-release.yml
🔇 Additional comments (1)
.github/workflows/pre-release.yml (1)
11-11: Tag refs will still pass this condition – consider guarding against accidental releases from tags
if: github.ref != 'refs/heads/main'blocks the job onmain, but tags (e.g.refs/tags/v1.2.3) also satisfy the condition.
If someone fires the workflow on a tag ref, you’ll end up bumping versions and pushing new commits that cannot be attached to a tag branch, and the final push step (Line 63) will fail.Add an extra guard or limit the dispatch trigger to branches:
- if: github.ref != 'refs/heads/main' + # Only run on non-main branches (never on tags) + if: startsWith(github.ref, 'refs/heads/') && github.ref != 'refs/heads/main'
Crunchyman-ralph
added a commit
to iamladi/claude-task-master
that referenced
this pull request
Aug 11, 2025
* chore: improve pre-release CI to just use dropdown * chore: implement requested changes
Crunchyman-ralph
added a commit
to iamladi/claude-task-master
that referenced
this pull request
Aug 11, 2025
* chore: improve pre-release CI to just use dropdown * chore: implement requested changes
stephanschielke
pushed a commit
to stephanschielke/cursor-task-master
that referenced
this pull request
Aug 22, 2025
* chore: improve pre-release CI to just use dropdown * chore: implement requested changes
stephanschielke
pushed a commit
to stephanschielke/cursor-task-master
that referenced
this pull request
Aug 22, 2025
* chore: improve pre-release CI to just use dropdown * chore: implement requested changes
16 tasks
sfc-gh-dflippo
pushed a commit
to sfc-gh-dflippo/task-master-ai
that referenced
this pull request
Dec 4, 2025
* chore: improve pre-release CI to just use dropdown * chore: implement requested changes
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Related Issues
How to Test This
# Example commands or stepsExpected result:
Contributor Checklist
npm run changesetnpm testnpm run format-check(ornpm run formatto fix)Changelog Entry
For Maintainers
Summary by CodeRabbit