Skip to content

fix: fix mcp tool call in extension#1070

Merged
Crunchyman-ralph merged 3 commits intonextfrom
fix/vscode.scope.command
Aug 2, 2025
Merged

fix: fix mcp tool call in extension#1070
Crunchyman-ralph merged 3 commits intonextfrom
fix/vscode.scope.command

Conversation

@Crunchyman-ralph
Copy link
Collaborator

@Crunchyman-ralph Crunchyman-ralph commented Aug 2, 2025

What type of PR is this?

  • 🐛 Bug fix
  • ✨ Feature
  • 🔌 Integration
  • 📝 Docs
  • 🧹 Refactor
  • Other:

Description

  • fix console.log directly being used in scope-adjutment.js breaking mcp

Related Issues

How to Test This

# Example commands or steps

Expected result:

Contributor Checklist

  • Created changeset: npm run changeset
  • Tests pass: npm test
  • Format check passes: npm run format-check (or npm run format to fix)
  • Addressed CodeRabbit comments (if any)
  • Linked related issues (if any)
  • Manually tested the changes

Changelog Entry


For Maintainers

  • PR title follows conventional commits
  • Target branch correct
  • Labels added
  • Milestone assigned (if applicable)

Summary by CodeRabbit

Summary by CodeRabbit

  • Refactor
    • Improved consistency of logging by using a centralized logging utility for task complexity adjustments and subtask regeneration.
    • Ensured task identifiers are always sent as strings during scope adjustment operations.

- fix console.log directly being used in scope-adjutment.js breaking mcp
@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2025

⚠️ No Changeset found

Latest commit: 2ddb085

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update two areas: logging in the task manager's scope adjustment script is centralized by replacing direct console.log calls with a log utility, and the webview task query hook now ensures the id parameter is always a string by explicitly converting taskId to a string in mutation functions. Additional formatting improvements were made in JSON and package files, minor code style refinements in a React component, and test mocks were extended without altering core logic.

Changes

Cohort / File(s) Change Summary
Centralized Logging in Task Manager
scripts/modules/task-manager/scope-adjustment.js
Replaces all console.log calls with a log utility function, standardizing log levels and message handling throughout the scope adjustment workflow.
Parameter Type Normalization in Webview Hook
apps/extension/src/webview/hooks/useTaskQueries.ts
Ensures the id parameter in mutation functions is always a string by wrapping taskId with String(taskId), preventing type inconsistencies in API payloads.
Formatting Adjustments in JSON and Package Files
.taskmaster/reports/task-complexity-report.json, .taskmaster/state.json, apps/extension/package.json, package.json
Applies formatting changes such as adding trailing newlines, switching indentation from spaces to tabs, and condensing multi-line arrays to single-line arrays without altering content or structure.
Code Style and Formatting in React Component
apps/extension/src/components/TaskDetails/AIActionsSection.tsx
Refactors import statements, state declarations, and JSX formatting for improved readability without changing behavior or logic.
Test Mock Extensions
tests/unit/scripts/modules/task-manager/scope-adjustment.test.js
Adds new mocked functions and modules to extend test coverage setup without modifying existing test case logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 30359e3 and 2ddb085.

📒 Files selected for processing (7)
  • .taskmaster/reports/task-complexity-report.json (1 hunks)
  • .taskmaster/state.json (1 hunks)
  • apps/extension/package.json (4 hunks)
  • apps/extension/src/components/TaskDetails/AIActionsSection.tsx (7 hunks)
  • apps/extension/src/webview/hooks/useTaskQueries.ts (3 hunks)
  • package.json (1 hunks)
  • tests/unit/scripts/modules/task-manager/scope-adjustment.test.js (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/vscode.scope.command

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Crunchyman-ralph Crunchyman-ralph merged commit 3fee751 into next Aug 2, 2025
6 of 7 checks passed
Crunchyman-ralph added a commit to iamladi/claude-task-master that referenced this pull request Aug 11, 2025
* fix: fix mcp tool call in extension

- fix console.log directly being used in scope-adjutment.js breaking mcp

* chore: run format and fix tests

* chore: format
Crunchyman-ralph added a commit to iamladi/claude-task-master that referenced this pull request Aug 11, 2025
* fix: fix mcp tool call in extension

- fix console.log directly being used in scope-adjutment.js breaking mcp

* chore: run format and fix tests

* chore: format
stephanschielke pushed a commit to stephanschielke/cursor-task-master that referenced this pull request Aug 22, 2025
* fix: fix mcp tool call in extension

- fix console.log directly being used in scope-adjutment.js breaking mcp

* chore: run format and fix tests

* chore: format
stephanschielke pushed a commit to stephanschielke/cursor-task-master that referenced this pull request Aug 22, 2025
* fix: fix mcp tool call in extension

- fix console.log directly being used in scope-adjutment.js breaking mcp

* chore: run format and fix tests

* chore: format
sfc-gh-dflippo pushed a commit to sfc-gh-dflippo/task-master-ai that referenced this pull request Dec 4, 2025
* fix: fix mcp tool call in extension

- fix console.log directly being used in scope-adjutment.js breaking mcp

* chore: run format and fix tests

* chore: format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant