fix: normalize task IDs to numbers on load to fix comparison issues

[Crunchyman-ralph]

🐛 Bug Fix

🔍 Bug Description

When tasks.json contains string IDs (e.g., "5" instead of 5), task lookups fail because the code uses parseInt() and strict equality (===) for comparisons.

This fix normalizes all task and subtask IDs to numbers when loading the JSON, ensuring consistent comparisons throughout the codebase without requiring changes to multiple comparison locations.

Fixes task not found errors when using string IDs in tasks.json.

🔗 Related Issues

Reported on Discord: https://discord.com/channels/1354594356702478356/1398333561366642792

How to Test

Steps that caused the bug:

1. Wrap id fields within "" (as strings) in tasks.json.
2. run /bin/task-master.js show 5

Expected result:
Task will be found as it should.

Quick verification:

# Commands to verify the fix

Contributor Checklist

• Created changeset: npm run changeset
• Tests pass: npm test
• Format check passes: npm run format-check
• Addressed CodeRabbit comments
• Added unit tests (if applicable)
• Manually verified the fix works

---

For Maintainers

• Root cause identified
• Fix doesn't introduce new issues
• CI passes

Summary by CodeRabbit

• Bug Fixes

  • Resolved issues with task and subtask identification when IDs are provided as strings, including dotted notation.
  • Improved detection of tag-specific complexity report files in the expand command, ensuring correct file selection based on tag context.

• Tests

  • Added test cases to verify correct handling and normalization of string and dotted task IDs.

• Chores

  • Updated command-line option descriptions for clarity and removed unnecessary default values to support improved file detection.

[changeset-bot]

🦋 Changeset detected

Latest commit: b594795

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Caution

Review failed

Failed to post review comments.

Walkthrough

This update introduces normalization of task and subtask IDs from strings to numbers, ensuring consistent numeric identification throughout the codebase. It also fixes the expand command to correctly detect tag-specific complexity report files, removes a default CLI option to enable this detection, and adds a test for handling string and dotted IDs.

Changes

Cohort / File(s)	Change Summary
Changeset Metadata .changeset/eleven-horses-shop.md, .changeset/fix-tag-complexity-detection.md	Adds patch-level changesets describing fixes for task ID normalization and tag-specific complexity report detection.
CLI Command Option Update scripts/modules/commands.js	Removes the default value for the --complexity-report CLI option and clarifies its description to support tag-specific report detection.
Task ID Normalization Utility scripts/modules/utils.js	Introduces normalizeTaskIds to convert string IDs (including dotted notation) to positive numbers, applies normalization in task data loading, and exports the utility.
Test Coverage for ID Normalization tests/unit/task-finder.test.js	Adds tests to verify correct handling and normalization of string and dotted notation IDs in tasks and subtasks.

Sequence Diagram(s)

sequenceDiagram
    participant CLI_User
    participant CLI_Expand_Command
    participant Utils
    participant FileSystem

    CLI_User->>CLI_Expand_Command: Run expand with tag context
    CLI_Expand_Command->>FileSystem: Detect tag-specific complexity report file
    FileSystem-->>CLI_Expand_Command: Return tag-specific report
    CLI_Expand_Command->>Utils: Load and normalize task IDs (if needed)
    Utils-->>CLI_Expand_Command: Return normalized tasks
    CLI_Expand_Command-->>CLI_User: Complete expand operation with correct report and IDs

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• fix: remove default value from complexity report option to enable tag-specific detection #1049: The main PR includes the same change to the expand command's complexity report option, specifically removing the default value to enable tag-specific complexity report detection.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-task-not-found

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.