Skip to content

Conversation

oatmael
Copy link
Contributor

@oatmael oatmael commented Jul 3, 2024

Fixes issue #22 that causes host functions with arguments to not work on PHP 7.4.
See issue for context.

@oatmael oatmael changed the title Update input / output enum cast to map C Enum outside of FFI fix: Host Functions of PHP 7.4 Jul 3, 2024
@mhmd-azeez mhmd-azeez self-requested a review July 3, 2024 07:43
Copy link
Contributor

@mhmd-azeez mhmd-azeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks! I will wait for the rate limit to go away and run the CI again and then merge the PR

@mhmd-azeez mhmd-azeez merged commit ac61e14 into extism:main Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants