Skip to content

Conversation

@G4Vi
Copy link
Contributor

@G4Vi G4Vi commented Dec 29, 2023

Resolves #14

feat:

  • add Plugin::reset
  • implement WasmSourceBytes

fix:

  • Manifest: serialize header values correctly
  • current_plugin - when outputting, check against output range correctly
  • Function namespace constructor - actually construct

chore:

  • protect various class members
  • move non-initializer list constructors out of header
  • reduce copying with std::move
  • bump to C++ 17
  • remove ManifestKey, the stl containers and std::optional are sufficient
  • use std::unique_ptr to more safely manage Plugin's ExtismPlugin lifetime
  • make std::string no longer required for plugin calls. The duplication introduced can be removed with std::string_view if sdk: consider switching away from null terminated strings to ptr and length extism#646 is accepted and implemented
  • make jsoncpp a private dependency. This improves build times and makes the cpp-sdk not opinionated about what json library the user uses, if any.
  • use size_t instead of ExtismSize when referring to items in native memory / not using libextism

@G4Vi G4Vi requested a review from zshipko December 29, 2023 20:41
Copy link
Contributor

@zshipko zshipko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@G4Vi G4Vi requested a review from zshipko December 30, 2023 03:22
@G4Vi G4Vi merged commit 7757912 into main Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

header improvements

3 participants