-
Notifications
You must be signed in to change notification settings - Fork 5
feat/build: cmake packages #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 983f902.
…get if it doesnt exist
zshipko
approved these changes
Dec 4, 2023
Contributor
zshipko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies a somewhat more modern approach to cmake dependency handling. The next step after this is revamping the README with a Getting Started guide.
extismandjsoncppare now always linked via cmake targets instead of sometimes doing a filename search of libraries, whether they are included withadd_subdirectory,find_packageorFetchContent.extism,jsoncpp, andcpp-sdkall in the same directory. Including them withincpp-sdkmade having a flat dependency tree impossible.extismandjsoncppdependencies withFetchContent. If the build is not an in-tree build andfind_packagefails, they are downloaded and built.extism-cppCMake package to more easily integrate thecpp-sdkwith non-intree build projects.find_packageand the test target is not built if it's not found.cmakeandpkg-configmay be used to get the right flags..clang-format, it appears to be the style aready used.