Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: minimize binary size #98

Merged
merged 1 commit into from
Aug 6, 2024
Merged

ci: minimize binary size #98

merged 1 commit into from
Aug 6, 2024

Conversation

hellodword
Copy link
Contributor

make released binaries reproducible
use sha256 instead of md5
make sure CGO_ENABLED=0

@hellodword
ci: minimize binary size
789ec5d 
make released binaries reproducible
use sha256 instead of md5
make sure CGO_ENABLED=0
@hellodword hellodword mentioned this pull request Aug 4, 2024
Open
@G4Vi G4Vi requested review from zshipko and mhmd-azeez August 5, 2024 18:17
zshipko
zshipko approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@zshipko zshipko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Building extism on my machine with these changes results in an executable that's ~5MB smaller

@zshipko zshipko merged commit 648f5fb into extism:main Aug 6, 2024
6 of 7 checks passed
@hellodword hellodword deleted the patch-1 branch August 6, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zshipko zshipko zshipko approved these changes

@mhmd-azeez mhmd-azeez Awaiting requested review from mhmd-azeez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hellodword @zshipko