Make do_encode and do_decode eligible for Tail-Call Optimization #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayesgm
approved these changes
Jan 16, 2018
Contributor
hayesgm
left a comment
hayesgm
left a comment
There was a problem hiding this comment.
Lgtm. Can you add a note in changelog and add yourself to contributors.
Contributor
Author
|
Sure, will do. |
Contributor
Author
|
Actually, I don't see a contributors list in the repo files anywhere; what did you mean for me to add myself to? |
Contributor
|
@tsutsu in |
Contributor
Author
|
Ah, do you mean the Hex |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like with exthereum/evm#32,
ABI.TypeEncoder.do_encode/2andABI.TypeDecoder.do_decode/2are performing operations after the recursive self-call, and so can blow their stacks. This PR rephrases them into tail-call-with-accumulator style.Bonus efficiency fix: instead of repeatedly joining binaries in
do_encode/2, aniolist()is built and then baked into a binary at the end using:erlang.iolist_to_binary/1.No visible behaviour changes. Tests pass.