feat: push secret triggers for data as well#47
Merged
Conversation
Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com>
There was a problem hiding this comment.
Pull Request Overview
This PR extends the push secret trigger functionality to include secret matching based on data entries, ensuring that both secret selectors and data criteria are considered.
- Added a loop in the handler to check if any data entry's remote key matches the secret identifier.
- Updated CRD documentation and API type comments to reflect the new trigger criteria.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/handler/pushsecret/handler.go | Added a loop to verify secret identifier against data entries. |
| config/crd/bases/reloader.external-secrets.io_configs.yaml | Removed outdated description details to align with updated functionality. |
| api/v1alpha1/destination_pushsecret_types.go | Updated comments to document the new matching criteria for secret triggers. |
Files not reviewed (1)
- go.mod: Language not supported
msfernandes
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.