deployment/handler: pass variadic ListOption to avoid nil panic#325
Merged
Skarlso merged 1 commit intoMay 2, 2026
Merged
Conversation
Closes external-secrets#281. SQS events have empty Namespace; nil ListOption panics in client.List. Signed-off-by: SAY-5 <say.apm35@gmail.com>
SAY-5
force-pushed
the
fix/deployment-filter-nil-listoption-281
branch
from
May 2, 2026 03:48
fbb3111 to
529ef7a
Compare
Contributor
|
Thanks! :) |
Skarlso
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #281.
Filterdeclaresvar opt client.ListOptionand only assigns whenevent.Namespace != "". SQS events have an empty Namespace, soclient.Listis called with a nil ListOption and panics. Switch toopts ...client.ListOptionand pass variadic.