Skip to content

Update busboy link pointing to nonexistent section - #1447

Merged
UlisesGascon merged 1 commit into
expressjs:mainfrom
krzysdz:patch-1
Aug 5, 2026
Merged

Update busboy link pointing to nonexistent section#1447
UlisesGascon merged 1 commit into
expressjs:mainfrom
krzysdz:patch-1

Conversation

@krzysdz

@krzysdz krzysdz commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Busboy readme file structure changed when 1.0.0 was released (in mscdex/busboy@54a8683 to be exact).

@krzysdz

krzysdz commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

By the way, it might be worth noting in the readme that fieldNestingDepth is a limit enforced by multer and not busboy:

An object specifying the size limits of the following optional properties. Multer passes this object into busboy directly, and the details of the properties can be found on [busboy's page](https://github.com/mscdex/busboy#busboy-methods).

It took me a moment to realise that the details of the fieldNestingDepth property can't be found on busboy's page.

@krzysdz

krzysdz commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Speaking of fieldNestingDepth, this seems to be incorrect:

- `fieldNestingDepth` -- set to the minimum depth your field names require (e.g. `3` for `a[b][c]`)

a[b][c] should work with fieldNestingDepth: 2 as suggested earlier in the readme.

Additionally, shouldn't it be set to the maximum depth that field names require?

@UlisesGascon

Copy link
Copy Markdown
Member

I agree! We need to work a bit on fieldNestingDepth 👍

@UlisesGascon
UlisesGascon merged commit 7325907 into expressjs:main Aug 5, 2026
22 checks passed
@krzysdz
krzysdz deleted the patch-1 branch August 5, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants