Added enableObjectStream option

[SnakeA]

Background

I've got a similar use case with the issue raised: #181.

I am using Morgan for a lot of my projects and I would like to be able to write an Object in a stream instead of just a string.

Reason is that I am using Winston which supports meta-data for reach-er logs. I would like to use morgan and pass an object to Winston - instead of parsing a string.

Changes

• Added a backwards compatible enableObjectStream in morgan() call.
• Defaults to false
• It needs a custom format function and a defined stream to work.
• The only diff is that if the above are true (customFormatFunction && stream && enableObjectStream), we are not concatenating a \n (newline char), hence morgan can stream an object.

Any improvements/changes are welcome.

TODO:

• Update README
• Update HISTORY

but I'd like to get some opinions first 😄

[SnakeA]

@dougwilson Could you please have a look 😄 Thanks !

[dougwilson]

I will after the express 4.17 release is out, as there was a premature vulnerability listed and it is our number 1 priority right now, I hope you understand.

[SnakeA]

@dougwilson
Thank you for getting back to me 😄 No worries I do understand that you have other priorities

I did some digging and I've realised that a lot of people tried to make this change to Morgan but it never went out.

Morgan is being used by numerous of our project and does the job, other than the fact that it emits a string that we have to parse.

It would be great if we can work something out, otherwise, we might have to implement our own middleware

Thanks again and looking forward to your review & opinion

[SnakeA]

@dougwilson

Any updates?
I can see that express 4.17 was released last week?

Thanks!

[dougwilson]

Sorry, still getting reports about 4.17 from users. Here is a very quick review for points to work on:

1. No docs for new feature in pr
2. Does not work right when buffer feature enabled
3. Silently does nothing when using built in formatters. It could throw an error or at least be documented.

I hope this feedback helps while I am working on 4.17 issues in parallel.