Adding to scripts #177
Closed
Adding to scripts #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougwilson
suggested changes
Oct 27, 2017
Contributor
dougwilson
left a comment
dougwilson
left a comment
There was a problem hiding this comment.
Hi @BStudies thanks for the PR! I'm not sure if this is a desired addition, would like to hear from other collaborators.
Regardless of that, the PR itself seems to have two issues as-is: (1) it makes the current test suite fail and (2) there are no tests or documentation for these added scripts.
Contributor
|
Closing since I never heard back. If you want to make alterations feel free to make them and open a new PR of course! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey expressjs admins, I am not sure if you guys will decide to add this very minor change, just adding the debugger to the scripts.