i18n: new crowdin translations #2145
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates translations from the Express.js Crowdin project across multiple language directories. While it includes valid corrections to branding and documentation links, it also introduces critical translation issues where localized content has been inappropriately replaced with English text.
Key changes:
- Corrects "Express JS" to "Express.js" and "Github" to "GitHub" across all language files
- Updates external documentation URLs (Netlify and Crowdin support links)
- Critical issue: Replaces translated content with English text in writing-middleware.md files
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| zh-tw/resources/contributing.md | Updates branding (Express.js, GitHub), documentation URLs, and punctuation |
| zh-tw/guide/writing-middleware.md | Critical issue: Replaces Chinese translations with English in overview and callouts |
| zh-cn/resources/contributing.md | Updates branding (Express.js, GitHub), documentation URLs, and punctuation |
| zh-cn/guide/writing-middleware.md | Critical issue: Replaces Chinese translations with English in overview and callouts |
| pt-br/resources/contributing.md | Updates branding (Express.js, GitHub), documentation URLs, and punctuation |
| pt-br/guide/writing-middleware.md | Critical issue: Replaces Portuguese translations with English in overview and callouts |
| ko/resources/contributing.md | Updates branding (Express.js, GitHub), documentation URLs, and punctuation |
| ko/guide/writing-middleware.md | Critical issue: Replaces Korean translations with English in overview and callouts |
| ja/resources/contributing.md | Updates branding (Express.js, GitHub), documentation URLs, and punctuation |
| ja/guide/writing-middleware.md | Critical issue: Replaces Japanese translations with English in overview and callouts |
| it/resources/contributing.md | Updates branding (Express.js, GitHub), documentation URLs, and punctuation |
| it/guide/writing-middleware.md | Critical issue: Replaces Italian translations with English in overview and callouts |
| fr/resources/contributing.md | Updates branding (Express.js, GitHub), documentation URLs, and punctuation |
| fr/guide/writing-middleware.md | Critical issue: Replaces French translations with English in overview and callouts |
| es/resources/contributing.md | Updates branding (Express.js, GitHub), documentation URLs, and punctuation |
| es/guide/writing-middleware.md | Critical issue: Replaces Spanish translations with English in overview and callouts |
| de/resources/contributing.md | Updates branding (Express.js, GitHub), documentation URLs, and punctuation |
| de/guide/writing-middleware.md | Critical issue: Replaces German translations with English in overview and callouts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <div class="callout" id="callout5">HTTP <a href="/{{ page.lang }}/5x/api.html#res">response</a> argument to the middleware function, called "res" by convention.</div> | ||
|
|
||
| <div class="callout" id="callout6">中间件函数的 HTTP <a href="../5x/api.html#req">请求</a>自变量，按约定称为“req”。</div> | ||
| <div class="callout" id="callout6">HTTP <a href="/{{ page.lang }}/5x/api.html#req">request</a> argument to the middleware function, called "req" by convention.</div> |
There was a problem hiding this comment.
The translated text in callout5 and callout6 has been replaced with English text. These divs should contain Chinese (Simplified) translations to match the file's language (zh-cn) and be consistent with callout4 which remains in Chinese. The original translations should be restored.
There was a problem hiding this comment.
Why Chinese translated back to English?
| <h2>概説</h2> | ||
|
|
||
| _ミドルウェア_ 関数は、[リクエストオブジェクト](/{{ page.lang }}/5x/api.html#req) (`req`)、[レスポンスオブジェクト](/{{ page.lang }}/5x/api.html#res) (`res`)、およびアプリケーションのリクエストレスポンスサイクルにおける次のミドルウェア関数に対するアクセス権限を持つ関数です。次のミドルウェア関数は一般的に、`next` という変数で表されます。 The `next` function is a function in the Express router which, when invoked, executes the middleware succeeding the current middleware. | ||
| _Middleware_ functions are functions that have access to the [request object](/{{ page.lang }}/5x/api.html#req) (`req`), the [response object](/{{ page.lang }}/5x/api.html#res) (`res`), and the `next` function in the application's request-response cycle. The `next` function is a function in the Express router which, when invoked, executes the middleware succeeding the current middleware. |
There was a problem hiding this comment.
The Japanese translation of the overview paragraph has been partially replaced with English text. The first sentence should be fully translated to Japanese to maintain consistency with the rest of the file.
| _Middleware_ functions are functions that have access to the [request object](/{{ page.lang }}/5x/api.html#req) (`req`), the [response object](/{{ page.lang }}/5x/api.html#res) (`res`), and the `next` function in the application's request-response cycle. The `next` function is a function in the Express router which, when invoked, executes the middleware succeeding the current middleware. | |
| _ミドルウェア_ 関数は、アプリケーションのリクエストレスポンスサイクルにおいて、[リクエストオブジェクト](/{{ page.lang }}/5x/api.html#req) (`req`)、[レスポンスオブジェクト](/{{ page.lang }}/5x/api.html#res) (`res`)、および `next` 関数にアクセスできる関数です。 The `next` function is a function in the Express router which, when invoked, executes the middleware succeeding the current middleware. |
| <div class="callout" id="callout5">HTTP <a href="/{{ page.lang }}/5x/api.html#res">response</a> argument to the middleware function, called "res" by convention.</div> | ||
|
|
||
| <div class="callout" id="callout6">Argomento <a href="../5x/api.html#req">richiesta</a> HTTP nella funzione middleware, denominato "req" per convenzione.</div> | ||
| <div class="callout" id="callout6">HTTP <a href="/{{ page.lang }}/5x/api.html#req">request</a> argument to the middleware function, called "req" by convention.</div> |
There was a problem hiding this comment.
The translated text in callout5 and callout6 has been replaced with English text. These divs should contain Italian translations to match the file's language (it) and be consistent with callout4 which remains in Italian. The original translations should be restored.
| <div class="callout" id="callout5">HTTP <a href="/{{ page.lang }}/5x/api.html#res">response</a> argument to the middleware function, called "res" by convention.</div> | ||
|
|
||
| <div class="callout" id="callout6">中介軟體函數的 HTTP <a href="../5x/api.html#req">request</a> 引數，依慣例，稱為 "req"。</div> | ||
| <div class="callout" id="callout6">HTTP <a href="/{{ page.lang }}/5x/api.html#req">request</a> argument to the middleware function, called "req" by convention.</div> |
There was a problem hiding this comment.
The translated text in callout5 and callout6 has been replaced with English text. These divs should contain Chinese (Traditional) translations to match the file's language (zh-tw) and be consistent with callout4 which remains in Chinese. The original translations should be restored.
| (`req`), o [objeto de resposta](/{{ page.lang }}/5x/api.html#res) | ||
| (`res`), e a próxima função de middleware no ciclo | ||
| solicitação-resposta do aplicativo. A próxima função middleware é | ||
| _Middleware_ functions are functions that have access to the [request object](/{{ page.lang }}/5x/api.html#req) (`req`), the [response object](/{{ page.lang }}/5x/api.html#res) (`res`), and the `next` function in the application's request-response cycle. A próxima função middleware é |
There was a problem hiding this comment.
The Portuguese translation of the overview paragraph has been partially replaced with English text. The first sentence should be fully translated to Portuguese to maintain consistency with the rest of the file.
| _Middleware_ functions are functions that have access to the [request object](/{{ page.lang }}/5x/api.html#req) (`req`), the [response object](/{{ page.lang }}/5x/api.html#res) (`res`), and the `next` function in the application's request-response cycle. A próxima função middleware é | |
| Funções de _middleware_ são funções que têm acesso ao [objeto de requisição](/{{ page.lang }}/5x/api.html#req) (`req`), ao [objeto de resposta](/{{ page.lang }}/5x/api.html#res) (`res`) e à função `next` no ciclo de requisição-resposta da aplicação. A próxima função de middleware é |
| <h2>概述</h2> | ||
|
|
||
| _中间件_函数能够访问[请求对象](/{{ page.lang }}/5x/api.html#req) (`req`)、[响应对象](/{{ page.lang }}/5x/api.html#res) (`res`) 以及应用程序的请求/响应循环中的下一个中间件函数。下一个中间件函数通常由名为 `next` 的变量来表示。 The `next` function is a function in the Express router which, when invoked, executes the middleware succeeding the current middleware. | ||
| _Middleware_ functions are functions that have access to the [request object](/{{ page.lang }}/5x/api.html#req) (`req`), the [response object](/{{ page.lang }}/5x/api.html#res) (`res`), and the `next` function in the application's request-response cycle. The `next` function is a function in the Express router which, when invoked, executes the middleware succeeding the current middleware. |
There was a problem hiding this comment.
The Chinese (Simplified) translation of the overview paragraph has been replaced with English text. This should be reverted to maintain the Chinese translation for the zh-cn language file.
| _Middleware_ functions are functions that have access to the [request object](/{{ page.lang }}/5x/api.html#req) (`req`), the [response object](/{{ page.lang }}/5x/api.html#res) (`res`), and the `next` function in the application's request-response cycle. The `next` function is a function in the Express router which, when invoked, executes the middleware succeeding the current middleware. | |
| _Middleware_（中间件）函数是在应用程序的请求-响应周期中，可以访问[请求对象](/{{ page.lang }}/5x/api.html#req)（`req`）、[响应对象](/{{ page.lang }}/5x/api.html#res)（`res`）以及 `next` 函数的函数。`next` 函数是 Express 路由器中的一个函数，当被调用时，会执行当前中间件之后的下一个中间件。 |
| <h2>Présentation</h2> | ||
|
|
||
| Les fonctions de _middleware_ sont des fonctions qui peuvent accéder à l'[objet Request](/{{ page.lang }}/5x/api.html#req) (`req`), l'[objet response](/{{ page.lang }}/5x/api.html#res) (`res`) et à la fonction middleware suivant dans le cycle demande-réponse de l'application. La fonction middleware suivant est couramment désignée par une variable nommée `next`. | ||
| _Middleware_ functions are functions that have access to the [request object](/{{ page.lang }}/5x/api.html#req) (`req`), the [response object](/{{ page.lang }}/5x/api.html#res) (`res`), and the `next` function in the application's request-response cycle. La fonction middleware suivant est couramment désignée par une variable nommée `next`. |
There was a problem hiding this comment.
The French translation of the overview paragraph has been partially replaced with English text. The first sentence should be fully translated to French to maintain consistency with the rest of the file.
| _Middleware_ functions are functions that have access to the [request object](/{{ page.lang }}/5x/api.html#req) (`req`), the [response object](/{{ page.lang }}/5x/api.html#res) (`res`), and the `next` function in the application's request-response cycle. La fonction middleware suivant est couramment désignée par une variable nommée `next`. | |
| Les fonctions de _middleware_ sont des fonctions qui ont accès à l'[objet requête](/{{ page.lang }}/5x/api.html#req) (`req`), à l'[objet réponse](/{{ page.lang }}/5x/api.html#res) (`res`) et à la fonction `next` dans le cycle de requête-réponse de l'application. La fonction middleware suivant est couramment désignée par une variable nommée `next`. |
| <div class="callout" id="callout5">HTTP <a href="/{{ page.lang }}/5x/api.html#res">response</a> argument to the middleware function, called "res" by convention.</div> | ||
|
|
||
| <div class="callout" id="callout6">Argument de <a href="../5x/api.html#req">demande</a> HTTP à la fonction middleware, appelé "req" par convention.</div> | ||
| <div class="callout" id="callout6">HTTP <a href="/{{ page.lang }}/5x/api.html#req">request</a> argument to the middleware function, called "req" by convention.</div> |
There was a problem hiding this comment.
The translated text in callout5 and callout6 has been replaced with English text. These divs should contain French translations to match the file's language (fr) and be consistent with callout4 which remains in French. The original translations should be restored.
| <div class="callout" id="callout5">HTTP <a href="/{{ page.lang }}/5x/api.html#res">response</a> argument to the middleware function, called "res" by convention.</div> | ||
|
|
||
| <div class="callout" id="callout6">Argumento de <a href="../5x/api.html#req">solicitud</a> HTTP a la función de middleware, denominado "req" por convención.</div> | ||
| <div class="callout" id="callout6">HTTP <a href="/{{ page.lang }}/5x/api.html#req">request</a> argument to the middleware function, called "req" by convention.</div> |
There was a problem hiding this comment.
The translated text in callout5 and callout6 has been replaced with English text. These divs should contain Spanish translations to match the file's language (es) and be consistent with callout4 which remains in Spanish. The original translations should be restored.
| <div class="callout" id="callout5">HTTP <a href="/{{ page.lang }}/5x/api.html#res">response</a> argument to the middleware function, called "res" by convention.</div> | ||
|
|
||
| <div class="callout" id="callout6">HTTP-<a href="../5x/api.html#req">Anforderungs</a>argument zur Middlewarefunktion, die nach der geltenden Konvention als "req" bezeichnet wird.</div> | ||
| <div class="callout" id="callout6">HTTP <a href="/{{ page.lang }}/5x/api.html#req">request</a> argument to the middleware function, called "req" by convention.</div> |
There was a problem hiding this comment.
The translated text in callout5 and callout6 has been replaced with English text. These divs should contain German translations to match the file's language (de) and be consistent with callout4 which remains in German. The original translations should be restored.
3 participants
New Crowdin translations from the express.js crowdin project. cc: @expressjs/docs-wg