-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: content overflow on small screen #1948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I suggest fast-tracking this PR, as the overflow issue is affecting a all of users.
</table> | ||
<div class="methods-columns"> | ||
<ul> | ||
<li><code>checkout</code></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep the Markdown as it is. Jekyll performs several processes behind the scenes, especially for code highlighting, so I don't think we should move this to HTML.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should move this to HTML.
Tables aren't responsive by default, and the original layout caused horizontal overflow on small screens. I used semantic HTML <ul>
with Flexbox to solve this. It’s now responsive and easier to maintain for future design updates.
The only downside is having HTML in Markdown, which may slightly affect doc editing for contributors — but I think the improved UX and maintainability are worth it.
I think we should keep the Markdown as it is
As an alternative, we could also wrap Markdown lists in a styled <div class="">
to avoid full HTML, but that still requires some custom CSS.
<div class="">
- mkcol
- move
- m-search
- notify
- options
- patch
- post
</div>
We need to remove this unnecessary table. Let me know if you have any concerns with this approach.
closes #1831
preview https://deploy-preview-1948--expressjscom-preview.netlify.app/en/5x/api