docs: remove express v2 #1740
docs: remove express v2 #1740
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wesleytodd
left a comment
wesleytodd
left a comment
There was a problem hiding this comment.
Seems good, but as we discussed in the issue, it would be nice to have some docs on how to access them in case someone is looking.
|
Do you still require another reviewer? Or are you good to go? |
|
@chrisdel101 I am making some changes to set up the redirects |
bjohansebas
force-pushed
the
remove-express-v2
branch
from
d948c14 to
cf22434
Compare
|
I have applied the redirects on the pages that were from Express v2 and modified the 2x branch so that only version 2 is there. Additionally, in the README, I included some instructions on how to preview the content. By the way, @expressjs/express-tc can you add protection to the 2x branch so that it can only be read and not modified? |
chrisdel101
left a comment
chrisdel101
left a comment
There was a problem hiding this comment.
LGTM.
The only thing is whether we want the links to 2x branch left in on version support page, since it might be hard to find the 2x branch, but I assume you removed those to discourage people from even going there.
bjohansebas
force-pushed
the
remove-express-v2
branch
from
cf22434 to
7e5cb84
Compare
|
For a big PR like this, prefer to push regular commits and then squash at merge. That way during review it's simpler to know what has changed since last review. Based on your comment @bjohansebas the latest force push update was the redirects, but it's hard to tell with this many changed files |
jonchurch
left a comment
jonchurch
left a comment
There was a problem hiding this comment.
We can't actually get a true 301 out of Jekyll and Github pages here (or any static site builder) for what it's worth. Will be a 200 to load the page from CDN then a meta redir using JS (or the meta-http tag) on the loaded page itself.
Im okay with that for now, since we are also removing the Nav link from the site itself.
To fix that we'd need a page rule at Cloudflare, which requires additional config that Im not really convinced we want to maintain there.
|
I've enabled branch protections on the 2x branch (via rulesets, for anyone in the future looking for this in github settings) |
|
Yep, it's not the redirection I would like to have, but it's the only one allowed by GitHub Pages and Jekyll. |
5 participants
closes #1556