Skip to content

Conversation

@bjohansebas
Copy link
Member

There were several places where the use of admonitions is still not applied; this greatly improves the guidance in the documentation.

@bjohansebas bjohansebas requested a review from a team September 5, 2024 00:44
@netlify
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 7e4855d
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/6701a735cdfe710008dce3ed
😎 Deploy Preview https://deploy-preview-1595--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@carlosstenzel
Copy link
Contributor

The action (check-translation) is failing due to your repository permission not allowing writing, as discussed in other PRs

@carlosstenzel
Copy link
Contributor

Add manually to test if the action works

'{"labels":["requires-translation-es","requires-translation-fr","requires-translation-it","requires-translation-ja","requires-translation-ko","requires-translation-pt-br","requires-translation-ru","requires-translation-sk","requires-translation-zh-cn","requires-translation-zh-tw"]}',

@bjohansebas bjohansebas changed the base branch from gh-pages to perf-updates September 7, 2024 16:00
@bjohansebas bjohansebas changed the base branch from perf-updates to gh-pages September 7, 2024 16:01
@bjohansebas
Copy link
Member Author

bjohansebas commented Sep 7, 2024

The action (check-translation) is failing due to your repository permission not allowing writing, as discussed in other PRs

The permissions of my repository don't affect anything in the PRs; the rules in this repository do. That's why in this PR (#1588) it works fine, because @crandmck was the one who opened it.

@crandmck
Copy link
Member

crandmck commented Oct 5, 2024

Please resolve the merge conflicts and we can land this, thanks!

@bjohansebas
Copy link
Member Author

@crandmck done

@UlisesGascon UlisesGascon merged commit 2d58040 into expressjs:gh-pages Oct 6, 2024
chrisdel101 pushed a commit to chrisdel101/expressjs.com that referenced this pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants