Repository navigation
perf: set default html and json content types directly - #7516
Open
Abdel-Monaam-Aouini wants to merge 1 commit into
Open
Abdel-Monaam-Aouini wants to merge 1 commit into
Abdel-Monaam-Aouini wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
res.send(string)callsres.type('html')andres.json()setsapplication/jsonwhen no Content-Type is set. Both go through a mime lookup (mime.contentType) just to get backtext/html; charset=utf-8andapplication/json; charset=utf-8.This sets those two values directly, so the header is the same but the lookup is skipped. A micro benchmark shows the lookup costs ~200ns for
htmland ~100ns forapplication/json. I did not see a difference in a full request benchmark, it is within noise, so this is a small saving per response.Added tests that check the exact header value, that there is a single Content-Type header, HEAD requests, and that a type set earlier with
res.type()is kept.