Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
UlisesGascon
left a comment
There was a problem hiding this comment.
LGTM! It is a great contribution. Thanks @dynst for helping the project ❤️
I will ask @wesleytodd for an additional review just in case we have a different plan for eslint, but AFAIK we are good to go 👍
|
@UlisesGascon There is an open discussion expressjs/discussions#327 |
bjohansebas
left a comment
There was a problem hiding this comment.
I definitely prefer that we use neostandard rather than having to look up which rules to apply
|
@UlisesGascon But this PR also contain changes related modern js practice like |
ctcpip
left a comment
There was a problem hiding this comment.
I don't think we would accept this PR in its current state -- it's not just updating eslint, it's making a large number of code changes.
Also, we still have not yet come to an agreement on the future of linting for Express and related projects.
https://eslint.org/docs/latest/rules/no-unused-vars#caughterrors
The only noticeable change is that the no-unused-vars lint now warns about unused errors in
catch (e)statements by default.