Fix: Add type validation for sendStatus to prevent BigInt serialization error (#6756) #6758
+15
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6756
This PR adds type validation to
res.sendStatus()
to prevent uncaught TypeError when BigInt values are passed as status codes.Problem:
res.sendStatus(200n)
caused uncaught"Do not know how to serialize a BigInt"
errorsendStatus()
calledthis.status()
which internally usesJSON.stringify()
Solution:
sendStatus()
methodTypeError: Invalid status code
for non-number inputsChanges:
lib/response.js
test/res.sendStatus.js
Testing: