examples: defend from xss #4119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dougwilson |
UlisesGascon
approved these changes
Mar 25, 2020
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
@KoyamaSohei thanks for this PR!
LGTM ❤️
Member
|
@dougwilson should be merge it? :-) |
Contributor
|
I just rebased it and changed to escape html lib last night. Plan to get it merged today, yes. CI was still running when I went to sleep. |
Contributor
|
It looks like as of this morning, Travis CI is no longer connected to any of our repositories; I am investigating. |
dougwilson
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3992