lint: add semicolons automatically#3562
Closed
hiroppy wants to merge 1 commit into
Closed
Conversation
Contributor
|
There are missing semicolons because we are changing to StandardJS style https://github.com/expressjs/express/blob/master/Collaborator-Guide.md |
Contributor
Author
|
@dougwilson Oh ok, should we delete all semicolons? |
Contributor
|
As long as doing so will not create merge conflicts between the open PRs and master. And also no merge conflicts between master and the 5.0 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used Eslint's fix option.
And I would like to add a
"semi": ["error", "always"]after #3561 is merged.