Combinations of middleware series with "app.all" is broken since 4.18.0

looks like #4913 is not fixed in 4.18.2
this is part of my code:

app.use(middleware.a);

app.get('/*', getter.a);

app.post('/*', poster.a);

app.use(middleware.b);

app.use('/somepath/otherpath',
  middleware.c,
  middleware.d,
  middleware.e);

app.get('/*', getter.b);

app.all(
  '/unicorn',
  poster.b,
  poster.c,
  poster.d
);

POST /unicorn is not hitting app.all() but will work if changed to app.post()

what am I missing?

after short investigation, if I change the max sync stack to 1000, it works with my code
(

express/lib/router/index.js

Line 208 in dac7a04

if (++sync > 100) {

express/lib/router/route.js

Line 133 in dac7a04

if (++sync > 100) {

)

we have many app.all() routes in our code and this limit is not enough in our case

I can't reproduce your issue with the limited information you provided. Could you create a minimal reproducible example to help us? There are tests for the problem you're describing

Navigation Menu

Repository navigation

Combinations of middleware series with "app.all" is broken since 4.18.0 #6579

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Combinations of middleware series with "app.all" is broken since 4.18.0 #6579

Description

Activity

YuliaNormanHarambam commented on Jun 17, 2025

bjohansebas commented on Jul 12, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions