Skip to content

Commit

Permalink
docs: update collaborator guide for lint script
Browse files Browse the repository at this point in the history
  • Loading branch information
dougwilson committed Aug 6, 2017
1 parent 1dbaae5 commit 44881fa
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions Collaborator-Guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Open issues for the expressjs.com website in https://github.com/expressjs/expres
## PRs and Code contributions

* Tests must pass.
* Follow the [JavaScript Standard Style](http://standardjs.com/).
* Follow the [JavaScript Standard Style](http://standardjs.com/) and `npm run lint`.
* If you fix a bug, add a test.

## Branches
Expand All @@ -27,7 +27,9 @@ a future release of Express.
each new issue you work on, although not compulsory.
4. To run the test suite, first install the dependencies by running `npm install`,
then run `npm test`.
5. If the tests pass, you can commit your changes to your fork and then create
5. Ensure your code is linted by running `npm run lint` -- fix any issue you
see listed.
6. If the tests pass, you can commit your changes to your fork and then create
a pull request from there. Make sure to reference your issue from the pull
request comments by including the issue number e.g. `#123`.

Expand Down

1 comment on commit 44881fa

@chaines
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this takes care of issue #3078. Should be closed?

Please sign in to comment.