Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update working session link #283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjohansebas
Copy link
Member

No description provided.

@bjohansebas bjohansebas requested review from wesleytodd and a team October 15, 2024 20:40
@jonchurch
Copy link
Member

jonchurch commented Nov 20, 2024

What's the intent here? Does the TC link take you to a different zoom meeting?

@bjohansebas
Copy link
Member Author

Fix the link for the working session, as the links are different for the TC meeting and the working session.

@bjohansebas
Copy link
Member Author

Although maybe there is an option in pkgs/meet so that the template doesn't have to be duplicated?

@jonchurch
Copy link
Member

jonchurch commented Nov 20, 2024

Ah good to know.

Maintaining two nearly identical templates for a single link difference isn't ideal here.

We can update the pkgjs action to accept some data via options to pass in. That's a new feature to add.

Opened an Issue there to discuss pkgjs/meet#206

@jonchurch
Copy link
Member

A hack for now could be to check the issue title in the agenda template to determine if it's TC or Working session, and choose the link to use based on that.

Copy link
Member

@jonchurch jonchurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another workaround, for our specific case, would be to check the title in the template. Im pretty sure it gets passed into the template as a title

We can check that to differentiate between the two types of meetings inside the ejs template and pick a meeting link that way.

@bjohansebas
Copy link
Member Author

@jonchurch That's a very good idea, I'll try it later.

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt check the time changes, but I assume these are reflective of the correct times or they wouldn't have been updated? Should we update the comment above? Is this because it is not taking into account DST?

@bjohansebas
Copy link
Member Author

Yes, the time change is to reflect the correct time, which is now one hour later, just like it was before #253.

@bjohansebas
Copy link
Member Author

I've created a PR to add the option and avoid implementing the proposed hack

see: pkgjs/meet#207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants