Added help text for cases where origin is not present #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougwilson
suggested changes
Feb 23, 2018
README.md
Outdated
| @@ -115,6 +115,20 @@ app.listen(80, function () { | |||
| }) | |||
| ``` | |||
|
|
|||
| If you want to enable access using CuRL or any other REST Tool / Server without origin, use `corsOptions` like this: | |||
There was a problem hiding this comment.
I've never seen curl written that way before. Can the capitalization just match what is used on the tool's site? https://curl.haxx.se
There was a problem hiding this comment.
@dougwilson Done.
AbhishekBiswal
commented
Feb 23, 2018
dougwilson
approved these changes
Jun 22, 2018
dougwilson
pushed a commit
to AbhishekBiswal/cors
that referenced
this pull request
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of times when using the code snippet for dynamic origins, developers miss out on cases where origin is not present. For example, while using a Rest tool like Postman or making requests from a server.