Don't copy chunks if they're already buffers #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Indeed, it does copy the underlying data into a new buffer, which is definitely unnecessary. This looks good, and I'll get this merged tomorrow with your other PR 🎉 |
dougwilson
approved these changes
Mar 13, 2019
Contributor
dougwilson
left a comment
dougwilson
left a comment
There was a problem hiding this comment.
I hope you don't mind, but I added a function to reduce the line length since I was rebasing the PR anyhow.
Contributor
Author
|
Not at all! :) Thanks |
AnkushLambdatest
pushed a commit
to AnkushLambdatest/compression
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer.from(buffer)copies the buffer, which seems unnecessary. What do you think?