-
-
Notifications
You must be signed in to change notification settings - Fork 9
feat(sendfile): add migration for res.sendfile to res.sendFile #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "name": "@expressjs/camelcase-sendfile", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good naming 👌🏻
| METHOD: { regex: '^(sendfile)$' }, | ||
| }, | ||
| }) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (!nodes.lenght) return null; |
| edits.push(method.replace('sendFile')) | ||
| } | ||
|
|
||
| if (edits.length === 0) return null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (edits.length === 0) return null | |
| if (!edits.length) return null | |
Following up on #97, the other codemod that was part of v4-deprecated-signatures has now been migrated to ast-grep.