-
-
Notifications
You must be signed in to change notification settings - Fork 9
feat(pluralize-deprecated-methods): migrate pluralize-methods to codemod.com #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9bb7718
feat(pluralize-deprecated-methods): migrate pluralize-methods to code…
bjohansebas 89a2840
rename codemod
bjohansebas 997bdc7
apply suggestions
bjohansebas 09a35ec
chore: update repository URL in codemod.yaml
bjohansebas c448967
Merge branch 'main' of github.com:expressjs/codemod into pluralized-m…
bjohansebas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # Migrate pluralized request methods | ||
|
|
||
| Migrates deprecated request methods to their pluralized versions that were deprecated in Express 4 and removed in Express 5. | ||
|
|
||
| ## Example | ||
|
|
||
| ### Migrating `req.acceptsCharset(charset)` | ||
|
|
||
| The migration involves replacing instances of `req.acceptsCharset(charset)` with `req.acceptsCharsets(charset)`. | ||
|
|
||
| ```diff | ||
| app.get('/', (req, res) => { | ||
| - const charset = req.acceptsCharset('utf-8'); | ||
| + const charset = req.acceptsCharsets('utf-8'); | ||
| res.json({ charset }); | ||
| }); | ||
| ``` | ||
| ### Migrating `req.acceptsEncoding(encoding) | ||
|
|
||
| The migration involves replacing instances of `req.acceptsEncoding(encoding)` with `req.acceptsEncodings(encoding)`. | ||
|
|
||
| ```diff | ||
| app.get('/', (req, res) => { | ||
| - const encoding = req.acceptsEncoding('gzip'); | ||
| + const encoding = req.acceptsEncodings('gzip'); | ||
| res.json({ encoding }); | ||
| }); | ||
| ``` | ||
|
|
||
| ### Migrating `req.acceptsLanguage(language)` | ||
|
|
||
| The migration involves replacing instances of `req.acceptsLanguage(language)` with `req.acceptsLanguages(language)`. | ||
|
|
||
| ```diff | ||
| app.get('/', (req, res) => { | ||
| - const language = req.acceptsLanguage('en'); | ||
| + const language = req.acceptsLanguages('en'); | ||
| res.json({ language }); | ||
| }); | ||
| ``` | ||
|
|
||
| ## References | ||
|
|
||
| - [Migration of pluralized request methods](https://expressjs.com/en/guide/migrating-5.html#plural) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| schema_version: "1.0" | ||
| name: "@expressjs/pluralize-method-names" | ||
| version: "1.0.0" | ||
| description: Migrates usage of deprecated singular request methods to their pluralized versions in Express.js applications. | ||
| author: bjohansebas (Sebastian Beltran) | ||
| license: MIT | ||
| workflow: workflow.yaml | ||
| repository: "https://github.com/expressjs/codemod/tree/HEAD/codemods/pluralize-method-names" | ||
| category: migration | ||
|
|
||
| targets: | ||
| languages: | ||
| - javascript | ||
| - typescript | ||
|
|
||
| keywords: | ||
| - transformation | ||
| - migration | ||
| - express | ||
| - accepts | ||
| - accepetsCharsets | ||
| - acceptsEncodings | ||
| - acceptsLanguages | ||
|
|
||
| registry: | ||
| access: public | ||
| visibility: public |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "name": "@expressjs/pluralize-method-names", | ||
| "private": true, | ||
| "version": "1.0.0", | ||
| "description": "Migrates usage of deprecated singular request methods to their pluralized versions in Express.js applications.", | ||
| "type": "module", | ||
| "scripts": { | ||
| "test": "npx codemod jssg test -l typescript ./src/workflow.ts ./" | ||
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/expressjs/codemod.git", | ||
| "directory": "codemods/pluralize-method-names", | ||
| "bugs": "https://github.com/expressjs/codemod/issues" | ||
| }, | ||
| "author": "bjohansebas (Sebastian Beltran)", | ||
| "license": "MIT", | ||
| "homepage": "https://github.com/expressjs/codemod/blob/main/codemods/pluralize-method-names/README.md", | ||
| "devDependencies": { | ||
| "@codemod.com/jssg-types": "^1.3.1" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import type Js from '@codemod.com/jssg-types/src/langs/javascript' | ||
| import type { Edit, SgRoot } from '@codemod.com/jssg-types/src/main' | ||
|
|
||
| async function transform(root: SgRoot<Js>): Promise<string | null> { | ||
| const rootNode = root.root() | ||
|
|
||
| const nodes = rootNode.findAll({ | ||
| rule: { | ||
| any: [ | ||
| { pattern: '$OBJ.$METHOD($ARG)' }, | ||
| { | ||
| pattern: '$OBJ.$METHOD()', | ||
| }, | ||
| ], | ||
| }, | ||
| constraints: { | ||
| METHOD: { regex: '^(acceptsCharset|acceptsEncoding|acceptsLanguage)$' }, | ||
| }, | ||
| }) | ||
|
|
||
| if (!nodes.length) return null | ||
|
|
||
| const edits: Edit[] = [] | ||
|
|
||
| for (const call of nodes) { | ||
| const method = call.getMatch('METHOD') | ||
| const obj = call.getMatch('OBJ') | ||
| if (!obj || !method) continue | ||
|
|
||
| const objDef = obj.definition({ resolveExternal: false }) | ||
| if (!objDef) continue | ||
|
|
||
| edits.push(method.replace(`${method.text()}s`)) | ||
| } | ||
|
|
||
| if (!edits.length) return null | ||
|
|
||
| return rootNode.commitEdits(edits) | ||
| } | ||
|
|
||
| export default transform | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import express from 'express' | ||
|
|
||
| const app = express() | ||
|
|
||
| app.get('/', (req, res) => { | ||
| const charset = req.acceptsCharsets(); | ||
| res.json({ charset }); | ||
| }); | ||
|
|
||
|
|
||
| app.get('/', (req, res) => { | ||
| const charset = req.acceptsCharsets('utf-8'); | ||
| res.json({ charset }); | ||
| }); | ||
|
|
||
| app.get('/', function (request, response) { | ||
| const charset = request.acceptsCharsets('utf-8'); | ||
| response.json({ charset }); | ||
| }); |
18 changes: 18 additions & 0 deletions
18
codemods/pluralize-method-names/tests/expected/encoding.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import express from 'express' | ||
|
|
||
| const app = express() | ||
|
|
||
| app.get('/', (req, res) => { | ||
| const encoding = req.acceptsEncodings(); | ||
| res.json({ encoding }); | ||
| }); | ||
|
|
||
| app.get('/', (req, res) => { | ||
| const encoding = req.acceptsEncodings('gzip'); | ||
| res.json({ encoding }); | ||
| }); | ||
|
|
||
| app.get('/', function (request, response) { | ||
| const encoding = request.acceptsEncodings('gzip'); | ||
| response.json({ encoding }); | ||
| }); |
18 changes: 18 additions & 0 deletions
18
codemods/pluralize-method-names/tests/expected/language.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import express from 'express' | ||
|
|
||
| const app = express() | ||
|
|
||
| app.get('/', (req, res) => { | ||
| const encoding = req.acceptsLanguages(); | ||
| res.json({ encoding }); | ||
| }); | ||
|
|
||
| app.get('/', (req, res) => { | ||
| const encoding = req.acceptsLanguages('gzip'); | ||
| res.json({ encoding }); | ||
| }); | ||
|
|
||
| app.get('/', function (request, response) { | ||
| const encoding = request.acceptsLanguages('gzip'); | ||
| response.json({ encoding }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import express from 'express' | ||
|
|
||
| const app = express() | ||
|
|
||
| app.get('/', (req, res) => { | ||
| const charset = req.acceptsCharset(); | ||
| res.json({ charset }); | ||
| }); | ||
|
|
||
|
|
||
| app.get('/', (req, res) => { | ||
| const charset = req.acceptsCharset('utf-8'); | ||
| res.json({ charset }); | ||
| }); | ||
|
|
||
| app.get('/', function (request, response) { | ||
| const charset = request.acceptsCharset('utf-8'); | ||
| response.json({ charset }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import express from 'express' | ||
|
|
||
| const app = express() | ||
|
|
||
| app.get('/', (req, res) => { | ||
| const encoding = req.acceptsEncoding(); | ||
| res.json({ encoding }); | ||
| }); | ||
|
|
||
| app.get('/', (req, res) => { | ||
| const encoding = req.acceptsEncoding('gzip'); | ||
| res.json({ encoding }); | ||
| }); | ||
|
|
||
| app.get('/', function (request, response) { | ||
| const encoding = request.acceptsEncoding('gzip'); | ||
| response.json({ encoding }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import express from 'express' | ||
|
|
||
| const app = express() | ||
|
|
||
| app.get('/', (req, res) => { | ||
| const encoding = req.acceptsLanguage(); | ||
| res.json({ encoding }); | ||
| }); | ||
|
|
||
| app.get('/', (req, res) => { | ||
| const encoding = req.acceptsLanguage('gzip'); | ||
| res.json({ encoding }); | ||
| }); | ||
|
|
||
| app.get('/', function (request, response) { | ||
| const encoding = request.acceptsLanguage('gzip'); | ||
| response.json({ encoding }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # yaml-language-server: $schema=https://raw.githubusercontent.com/codemod-com/codemod/refs/heads/main/schemas/workflow.json | ||
|
|
||
| version: "1" | ||
|
|
||
| nodes: | ||
| - id: apply-transforms | ||
| name: Apply AST Transformations | ||
| type: automatic | ||
| runtime: | ||
| type: direct | ||
| steps: | ||
| - name: Migrates usage of deprecated singular request methods to their pluralized versions in Express.js applications. | ||
| js-ast-grep: | ||
| js_file: src/workflow.ts | ||
| base_path: . | ||
| semantic_analysis: file | ||
| include: | ||
| - "**/*.cjs" | ||
| - "**/*.js" | ||
| - "**/*.jsx" | ||
| - "**/*.mjs" | ||
| - "**/*.cts" | ||
| - "**/*.mts" | ||
| - "**/*.ts" | ||
| - "**/*.tsx" | ||
| exclude: | ||
| - "**/node_modules/**" | ||
| language: typescript |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.