Closed
Conversation
bjohansebas
reviewed
Jan 4, 2026
| matrix: | ||
| os: [ubuntu-latest, windows-latest, macos-latest] | ||
| node-version: [18, 19, 20, 21, 22, 23] | ||
| node-version: [18, 20, 22, 24, 25] |
Member
There was a problem hiding this comment.
Why remove those Node.js versions that are not LTS? In the other repositories we also keep CI running for those versions.
Suggested change
| node-version: [18, 20, 22, 24, 25] | |
| node-version: [18, 19, 20, 21, 22, 23, 24, 25] |
Contributor
There was a problem hiding this comment.
You can also use this action that took semver range and generate the aray
https://github.com/ljharb/actions/tree/main/node/matrix
example https://github.com/nodejs/userland-migrations/blob/8d2de45dee99f5906acf76b434d1251acf79730f/.github/workflows/ci.yml#L46
Member
|
We already have CI against those versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Node.js version to run ci against on push