supplied resource is not a valid stream resource #11

sm2017 · 2017-01-09T07:32:30Z

sm2017 · 2017-02-12T07:39:47Z

Reply please , I open this Issue on Jan 9 and I need to solve the problem , Help please

I test it in php5.6 and libevent , it works well but in php7 and libevent , I have this error

PHP Warning:  stream_set_blocking(): supplied resource is not a valid stream resource in /home/app/vendor/workerman/workerman/Connection/AsyncTcpConnection.php on line 263

Warning: stream_set_blocking(): supplied resource is not a valid stream resource in /home/app/vendor/workerman/workerman/Connection/AsyncTcpConnection.php on line 263
PHP Warning:  stream_set_read_buffer(): supplied resource is not a valid stream resource in /home/app/vendor/workerman/workerman/Connection/AsyncTcpConnection.php on line 266

Warning: stream_set_read_buffer(): supplied resource is not a valid stream resource in /home/app/vendor/workerman/workerman/Connection/AsyncTcpConnection.php on line 266
PHP Warning:  socket_import_stream(): supplied resource is not a valid stream resource in /home/app/vendor/workerman/workerman/Connection/AsyncTcpConnection.php on line 270

Warning: socket_import_stream(): supplied resource is not a valid stream resource in /home/app/vendor/workerman/workerman/Connection/AsyncTcpConnection.php on line 270
PHP Warning:  socket_set_option() expects parameter 1 to be resource, boolean given in /home/app/vendor/workerman/workerman/Connection/AsyncTcpConnection.php on line 271

Warning: socket_set_option() expects parameter 1 to be resource, boolean given in /home/app/vendor/workerman/workerman/Connection/AsyncTcpConnection.php on line 271
PHP Warning:  socket_set_option() expects parameter 1 to be resource, boolean given in /home/app/vendor/workerman/workerman/Connection/AsyncTcpConnection.php on line 272

Warning: socket_set_option() expects parameter 1 to be resource, boolean given in /home/app/vendor/workerman/workerman/Connection/AsyncTcpConnection.php on line 272
PHP Warning:  event_set(): fd argument must be either valid PHP stream or valid PHP socket resource in /home/app/vendor/workerman/workerman/Events/Libevent.php on line 105

Warning: event_set(): fd argument must be either valid PHP stream or valid PHP socket resource in /home/app/vendor/workerman/workerman/Events/Libevent.php on line 105
PHP Warning:  event_set(): fd argument must be either valid PHP stream or valid PHP socket resource in /home/app/vendor/workerman/workerman/Events/Libevent.php on line 105

Warning: event_set(): fd argument must be either valid PHP stream or valid PHP socket resource in /home/app/vendor/workerman/workerman/Events/Libevent.php on line 105

sm2017 · 2017-02-12T07:40:33Z

@ichiriac Help me

ichiriac · 2017-02-12T16:56:02Z

Hi @sm2017,

Sorry, I've not saw your issue before today. I think the problem comes with this statement :
https://github.com/walkor/Workerman/blob/master/Connection/AsyncTcpConnection.php#L261

Running this statement :
https://github.com/walkor/Workerman/blob/master/Events/Libevent.php#L127

This will run into the code (and it's okay) :
https://github.com/expressif/pecl-event-libevent/blob/master/libevent.c#L771

Not sure why (bad refcount maybe), but also seems to trigger this code :
https://github.com/expressif/pecl-event-libevent/blob/master/libevent.c#L153

I need to check this in debug mode but for me, when you call the del function, followed by event_del statement, it seems that the object after unset does not have any more references to him. The garbage collector passes, and kills the object (line 153 on libevent.c), and the ressource is also closed.

After investigations, this line is changes to be compliant with PHP7 (zend_list_delete to zend_list_close)

In most user extension functions like mysql_close(), you should use zend_list_close() instead of zend_list_delete(). This closes the actual connection and frees extension specific data structures, but doesn't free the zend_reference structure. that might be still referenced from zval(s). This also doesn't decrement the resource reference counter.

So when the event is destroyed (no more references to him), the connection is closed, that explains your warnings.

One solution could be to revert back to zend_list_delete but I believe that makes memory leaks (not sure).

Sorry but I have no time to work again on libevent, maybe in few month I will be back again on this but for now I'm stuck on other projects.

If you know C fork me and make a pull request, I'll check it and package it for windows libraries.

sm2017 · 2017-02-19T08:17:00Z

@ichiriac , I need to fix the bug , Please fix it ASAP and help me
Thanks

ichiriac · 2017-02-19T09:09:46Z

ok @sm2017, ping me back in 1 month if it's not moving. I'll update this issue when it will be fixed.

sm2017 · 2017-02-20T07:56:23Z

Thanks a lot , I will check this page periodically
Thanks again 👍

forkeer · 2017-02-20T08:11:07Z

@ichiriac i have this issue too but i forget that if you solve its nice help for me

sm2017 · 2017-03-08T05:44:17Z

@ichiriac Update me please

ichiriac · 2017-03-08T10:23:24Z

Hi @sm2017,

I'll take a look at this tonight

sm2017 · 2017-03-08T17:50:15Z

Thanks a lot 😆 👍

ichiriac · 2017-03-09T00:08:08Z

I'll continue tomorrow, I've did not succeed to force the GC with a small code

sm2017 · 2017-03-09T06:05:12Z

I hope , the following references helps

stream_socket_client - STREAM_CLIENT_ASYNC_CONNECT

https://github.com/walkor/Workerman/blob/master/Connection/AsyncTcpConnection.php#L171-L172

EV_WRITE

https://github.com/walkor/Workerman/blob/master/Connection/AsyncTcpConnection.php#L186

supplied resource is not a valid stream resource

https://github.com/walkor/Workerman/blob/master/Connection/AsyncTcpConnection.php#L263
https://github.com/walkor/Workerman/blob/master/Connection/AsyncTcpConnection.php#L266
https://github.com/walkor/Workerman/blob/master/Connection/AsyncTcpConnection.php#L270
https://github.com/walkor/Workerman/blob/master/Connection/AsyncTcpConnection.php#L271-L272

fd argument must be either valid PHP stream or valid PHP socket resource

https://github.com/walkor/Workerman/blob/master//Events/Libevent.php#L105

ichiriac · 2017-03-09T21:42:47Z

Hi @sm2017,

The issue should be fixed, can you try by rebuilding from sources or do you need windows binaries ?

I can't reproduce the bug directly as in PHP7 it's not easy to trigger the GC, so I need you to test and tell me if it's OK.

Then I'll take tome time to find out a way to trigger properly the garbage collector, in order to cover this ticket with tests

sm2017 · 2017-03-11T06:07:27Z

I install libevent @05900f3b8d70deb424b3193a4eb850062f146638 , but same result , I have supplied resource is not a valid stream resource error

Read http://php.net/manual/en/function.gc-collect-cycles.php maybe helps

sm2017 · 2017-03-12T08:46:23Z

See #16 I found that the problem is event_free that called at https://github.com/reactphp/event-loop/blob/master/src/LibEventLoop.php#L103

Before event_free the $fd is resource of type (stream) and after resource of type (Unknown) so in next lines we have supplied resource is not a valid stream resource error

ichiriac · 2017-03-12T08:49:12Z

ouch : https://github.com/expressif/pecl-event-libevent/blob/master/libevent.c#L605 - explicitely closes the list / was not the case before the migration : https://github.com/php/pecl-event-libevent/blob/master/libevent.c#L605

#11

sm2017 · 2017-03-12T08:59:55Z

I install again libevent extension and run test script the result is

<?php

/* poll STDIN using basic API */
function foo($fd, $events, $arg)
{
    static $i;

    $i++;

    if ($i == 10) {
        event_base_loopexit($arg[1]);
    }
    var_dump(fread($fd, 1));
}


$base = event_base_new();

$fd = fopen('https://raw.githubusercontent.com/expressif/pecl-event-libevent/master/tests/input.txt', 'r');

// first event reader
$ev1 = event_new();
var_dump(event_set($ev1, $fd, EV_READ | EV_PERSIST, "foo", array($ev1, $base)));
var_dump(event_base_set($ev1, $base));
var_dump(event_add($ev1));
var_dump(event_base_loop($base, EVLOOP_ONCE));
var_dump(event_del($ev1));
var_dump($fd);
event_free($ev1);
unset($ev1);
var_dump($fd);

// second event reader
$ev2 = event_new();
var_dump(event_set($ev2, $fd, EV_READ | EV_PERSIST, "foo", array($ev2, $base)));
var_dump(event_base_set($ev2, $base));
var_dump(event_add($ev2));
var_dump(event_base_loop($base, EVLOOP_ONCE));
var_dump(event_del($ev2));
unset($ev2);

?>

bool(true)
bool(true)
bool(true)
string(1) "0"
int(0)
bool(true)
resource(6) of type (stream)
resource(6) of type (Unknown)
PHP Warning:  event_set(): fd argument must be either valid PHP stream or valid PHP socket resource in /home/libeventBug/test.php on line 35
bool(false)
bool(false)
PHP Warning:  event_add(): Unable to add event without an event base in /home/libeventBug/test.php on line 37
bool(false)
int(1)
PHP Warning:  event_del(): Unable to delete event without an event base in /home/libeventBug/test.php on line 39
bool(false)
[warn] event_del: event has no event_base set.

#11

ichiriac · 2017-03-12T09:13:17Z

@sm2017, I'm looking at it, I'll tell you when it's fixed so you can test

sm2017 · 2017-03-12T09:17:38Z

@ichiriac Ok just I found another issue

See https://github.com/walkor/Workerman/blob/master/Events/Libevent.php#L84 , the 2th argument of event_set is 0 that is integer not resource , I see http://php.net/manual/en/function.event-set.php and 2th argument is mixed and Signal number or resource indicating the stream. but with expressif/pecl-event-libevent we have this error PHP Warning: event_set(): invalid file descriptor passed

ichiriac · 2017-03-12T09:55:34Z

@sm2017, this bug is now fixed, travis passed, waiting your confirmation.

For the other bug can you open a new issue and send a PR with a phpt to reproduce the error, check the output with php5 in order to get the output for the expected section.

sm2017 · 2017-03-12T10:07:41Z

I run test script and it works , but in main project I have issue let me find the problem

sm2017 · 2017-03-12T10:47:40Z

I think we have Segmentation fault in new commit

In this line https://github.com/walkor/Workerman/blob/152756a04f95645217d159f5a496077de0be65cd/Worker.php#L1022 we have pcntl_wait after I install libevent $status is SIGSEGV = 11

sm2017 · 2017-03-13T09:34:47Z

I want to create a phpt file for Segmentation fault bug , But I cannot , Can you help me?

I know the problem is event_add but cannot reproduce error

Please do following

git clone https://github.com/walkor/workerman-chat
cd workerman-chat
composer install
php start.php start

The code running in following order

https://github.com/walkor/GatewayWorker/blob/master/src/Gateway.php#L819
https://github.com/walkor/Workerman/blob/master/Connection/AsyncTcpConnection.php#L171
https://github.com/walkor/Workerman/blob/master/Connection/AsyncTcpConnection.php#L186
https://github.com/walkor/Workerman/blob/master/Events/Libevent.php#L113

The problem is https://github.com/walkor/Workerman/blob/master/Events/Libevent.php#L113 I don't know why in this line script will be terminated and send SIGSEGV to parent process

https://github.com/walkor/Workerman/blob/master/Worker.php#L1022

But in PHP 5.6 and libevent it workes well

ichiriac · 2017-03-24T13:51:18Z

Hi @sm2017,

This is another issue, we can continue here : #19

I will close this one as it's fixed.

sm2017 mentioned this issue Feb 19, 2017

LibEvent issue walkor/workerman#130

Closed

ichiriac self-assigned this Mar 8, 2017

ichiriac added the bug label Mar 8, 2017

ichiriac added this to the Stable / PHP7 milestone Mar 8, 2017

ichiriac added a commit that referenced this issue Mar 8, 2017

#11 add a test to reproduce the error

c52e993

ichiriac closed this as completed in 05900f3 Mar 9, 2017

ichiriac reopened this Mar 9, 2017

sm2017 mentioned this issue Mar 12, 2017

Bug of event_free #16

Merged

ichiriac added a commit that referenced this issue Mar 12, 2017

fix stream closing when calling event_free

2c45825

#11

ichiriac added a commit that referenced this issue Mar 12, 2017

Avoid closing the stream on event destructor

34f70c6

#11

ichiriac added a commit that referenced this issue Mar 12, 2017

#11 - fix stream destruction

e81d9df

sm2017 mentioned this issue Mar 13, 2017

status 11 walkor/workerman#152

Closed

ichiriac closed this as completed Mar 24, 2017

ichiriac mentioned this issue Mar 24, 2017

invalid file descriptor passed #19

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

supplied resource is not a valid stream resource #11

supplied resource is not a valid stream resource #11

sm2017 commented Jan 9, 2017

sm2017 commented Feb 12, 2017

sm2017 commented Feb 12, 2017

ichiriac commented Feb 12, 2017

sm2017 commented Feb 19, 2017

ichiriac commented Feb 19, 2017

sm2017 commented Feb 20, 2017

forkeer commented Feb 20, 2017

sm2017 commented Mar 8, 2017

ichiriac commented Mar 8, 2017

sm2017 commented Mar 8, 2017

ichiriac commented Mar 9, 2017

sm2017 commented Mar 9, 2017

ichiriac commented Mar 9, 2017 •

edited

Loading

sm2017 commented Mar 11, 2017

sm2017 commented Mar 12, 2017

ichiriac commented Mar 12, 2017

sm2017 commented Mar 12, 2017 •

edited

Loading

ichiriac commented Mar 12, 2017

sm2017 commented Mar 12, 2017

ichiriac commented Mar 12, 2017

sm2017 commented Mar 12, 2017

sm2017 commented Mar 12, 2017

sm2017 commented Mar 13, 2017

ichiriac commented Mar 24, 2017

supplied resource is not a valid stream resource #11

supplied resource is not a valid stream resource #11

Comments

sm2017 commented Jan 9, 2017

sm2017 commented Feb 12, 2017

sm2017 commented Feb 12, 2017

ichiriac commented Feb 12, 2017

sm2017 commented Feb 19, 2017

ichiriac commented Feb 19, 2017

sm2017 commented Feb 20, 2017

forkeer commented Feb 20, 2017

sm2017 commented Mar 8, 2017

ichiriac commented Mar 8, 2017

sm2017 commented Mar 8, 2017

ichiriac commented Mar 9, 2017

sm2017 commented Mar 9, 2017

stream_socket_client - STREAM_CLIENT_ASYNC_CONNECT

EV_WRITE

supplied resource is not a valid stream resource

fd argument must be either valid PHP stream or valid PHP socket resource

ichiriac commented Mar 9, 2017 • edited Loading

sm2017 commented Mar 11, 2017

sm2017 commented Mar 12, 2017

ichiriac commented Mar 12, 2017

sm2017 commented Mar 12, 2017 • edited Loading

ichiriac commented Mar 12, 2017

sm2017 commented Mar 12, 2017

ichiriac commented Mar 12, 2017

sm2017 commented Mar 12, 2017

sm2017 commented Mar 12, 2017

sm2017 commented Mar 13, 2017

ichiriac commented Mar 24, 2017

ichiriac commented Mar 9, 2017 •

edited

Loading

sm2017 commented Mar 12, 2017 •

edited

Loading