Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update validator to 13.7 #1115

Merged
merged 4 commits into from
Dec 11, 2021
Merged

feat: update validator to 13.7 #1115

merged 4 commits into from
Dec 11, 2021

Conversation

fedeci
Copy link
Member

@fedeci fedeci commented Dec 10, 2021 •
edited
Loading

Description

See validatorjs/validator.js/47ee5ad

/cc @tux-tn @gustavohenke

To-do list

  • I have added tests for what I changed.
  • This pull request is ready to merge.

@fedeci fedeci changed the title feat: add new locales feat: update validator to 13.7 Dec 10, 2021
@coveralls
Copy link

coveralls commented Dec 10, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling aca5448 on fedeci:fedeci/validator-13.7 into 5651810 on express-validator:master.

@fedeci fedeci marked this pull request as ready for review December 10, 2021 21:04
@fedeci fedeci added this to the v6.14.0 milestone Dec 10, 2021
@fedeci fedeci added the PR: dependencies Pull requests that update a dependency file label Dec 10, 2021
gustavohenke
gustavohenke approved these changes Dec 11, 2021
View reviewed changes
Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

src/chain/validators-impl.spec.ts Outdated Show resolved Hide resolved
src/chain/validators-impl.spec.ts Outdated Show resolved Hide resolved
@fedeci @gustavohenke
Apply suggestions from code review
aca5448 
Co-authored-by: Gustavo Henke <guhenke@gmail.com>
@fedeci fedeci merged commit f3cb5ba into express-validator:master Dec 11, 2021
@fedeci fedeci deleted the fedeci/validator-13.7 branch December 11, 2021 11:09
@tux-tn
Copy link

tux-tn commented Dec 11, 2021

great job @fedeci 🎉

@BodhithaW BodhithaW mentioned this pull request May 23, 2024
Open
@irklva irklva mentioned this pull request May 24, 2024
Open
@xilxil xilxil mentioned this pull request Jun 14, 2024
Open
@apiiro-snyk apiiro-snyk mentioned this pull request Jun 21, 2024
Open
@Aphelmion Aphelmion mentioned this pull request Aug 4, 2024
Closed
This was referenced Sep 8, 2024
Open
Open
@irklva irklva mentioned this pull request Sep 9, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Sep 9, 2024
Open
@BodhithaW BodhithaW mentioned this pull request Sep 9, 2024
Open
This was referenced Sep 11, 2024
Open
Open
@irklva irklva mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 13, 2024
Open
Open
@aarnold23 aarnold23 mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 14, 2024
Open
Open
Open
Open
This was referenced Sep 17, 2024
Open
Open
This was referenced Sep 19, 2024
Open
Open
Open
Open
@irklva irklva mentioned this pull request Sep 20, 2024
Open
This was referenced Sep 21, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavohenke gustavohenke gustavohenke approved these changes

Assignees
No one assigned
Labels
PR: dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v6.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fedeci @coveralls @tux-tn @gustavohenke