Skip to content

Conversation

bizywizy
Copy link
Contributor

Seconds attempt at implementing this:

all(x, x > 1) && all(x, x < 10) -> all(x, x > 1 && x < 10)
any(x, x > 1) || any(x, x < 10) -> any(x, x > 1 || x < 10)
none(x, x > 1) && none(x, x < 10) -> none(x, x > 1 || x < 10)

Previous one (#555) wasn't successful and unfortunately introduced a significant bug (#624).

This time I focused only on 3 cases: all with and, any with or, none with and and included comprehensive tests for this optimization and logical operations between any/all/none/one

@antonmedv
Copy link
Member

On my benchmarks this gives 8%-12% boost. Nice job! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants