Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions expr_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1184,6 +1184,18 @@ func TestExpr(t *testing.T) {
`"hello"[1:3]`,
"el",
},
{
`[1, 2, 3]?.[0]`,
1,
},
{
`[[1, 2], 3, 4]?.[0]?.[1]`,
2,
},
{
`[nil, 3, 4]?.[0]?.[1]`,
nil,
},
}

for _, tt := range tests {
Expand Down Expand Up @@ -1281,6 +1293,16 @@ func TestExpr_optional_chaining_nested_chains(t *testing.T) {
assert.Equal(t, "baz", got)
}

func TestExpr_optional_chaining_array(t *testing.T) {
env := map[string]any{}
program, err := expr.Compile("foo?.[1]?.[2]?.[3]", expr.Env(env), expr.AllowUndefinedVariables())
require.NoError(t, err)

got, err := expr.Run(program, env)
require.NoError(t, err)
assert.Equal(t, nil, got)
}

func TestExpr_eval_with_env(t *testing.T) {
_, err := expr.Eval("true", expr.Env(map[string]any{}))
assert.Error(t, err)
Expand Down
10 changes: 10 additions & 0 deletions parser/parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -575,10 +575,16 @@ end:
func (p *parser) parsePostfixExpression(node Node) Node {
postfixToken := p.current
for (postfixToken.Is(Operator) || postfixToken.Is(Bracket)) && p.err == nil {
optional := postfixToken.Value == "?."
parseToken:
if postfixToken.Value == "." || postfixToken.Value == "?." {
p.next()

propertyToken := p.current
if optional && propertyToken.Is(Bracket, "[") {
postfixToken = propertyToken
goto parseToken
}
p.next()

if propertyToken.Kind != Identifier &&
Expand Down Expand Up @@ -662,8 +668,12 @@ func (p *parser) parsePostfixExpression(node Node) Node {
node = &MemberNode{
Node: node,
Property: from,
Optional: optional,
}
node.SetLocation(postfixToken.Location)
if optional {
node = &ChainNode{Node: node}
}
p.expect(Bracket, "]")
}
}
Expand Down
13 changes: 13 additions & 0 deletions parser/parser_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -747,6 +747,19 @@ func TestParse_optional_chaining(t *testing.T) {
},
},
},
{
"foo.bar?.[0]",
&ChainNode{
Node: &MemberNode{
Node: &MemberNode{
Node: &IdentifierNode{Value: "foo"},
Property: &StringNode{Value: "bar"},
},
Property: &IntegerNode{Value: 0},
Optional: true,
},
},
},
}
for _, test := range parseTests {
actual, err := parser.Parse(test.input)
Expand Down