Potential REL sharding issue

[peter-axion]

I use spacy-llm for RAG, so I have integrated pretty deeply into it and 0.7.0 broke my method of prompt generation. In the process of fixing it, I've noticed something that may be a more general bug.

The REL shard reducer unpacks RelationItem objects from each shard into a single vector.

The comment in the code says this is fine, but RelationItem objects include the entity index of the dep/dest of the relationship. I think that's going to be 0-based for each shard, so the unpacked list will not have the right relationships for all shards after the first.

[svlandeg]

Hi!

Thanks for the report - we'll look into this. It does seem like this good be a potential bug.

Do you happen to have some example code that reproduces the error?

[svlandeg]

0.7.0 broke my method of prompt generation

Can you specify how it broke? We didn't report any bwd-compat issues for 0.7.0, so we might need to look into this as well (and at least update the documentation if so). Perhaps move this topic to a separate discussion if you want to provide more details 🙏

[peter-axion]

I made a discussion here about it.

I will try to make a test case that replicates the error using only spacy-llm.