-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💫 Tidy up and auto-format .py files #2983
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambda vs. def
Mostly lemmatizer lookup tables and similar
ines
added
enhancement
Feature requests and improvements
meta
Meta topics, e.g. repo organisation and issue management
⚠️ wip
Work in progress
labels
Nov 29, 2018
This was referenced Jun 25, 2021
This was referenced Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Feature requests and improvements
meta
Meta topics, e.g. repo organisation and issue management
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
black
to auto-format all.py
files.black
,flake8
, when to use# fmt: off
and# fmt: on
and what# noqa
means)Once #2932 is merged, which auto-formats and tidies up the CLI, we'll be able to run
flake8 spacy
actually get meaningful results.At the moment, the code style and linting isn't applied automatically, but I'm hoping that the new GitHub Actions will let us auto-format pull requests and post comments with relevant linting information.
Types of change
enhancement, code style
Checklist