Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker Image for Website Dev #10098

Merged
merged 5 commits into from
Jan 20, 2022
Merged

Docker Image for Website Dev #10098

merged 5 commits into from
Jan 20, 2022

Conversation

pmbaumgartner
Copy link
Contributor

Adds a Dockerfile for a repeatable build of the website with a working version of node/npm and instructions for accessing the images through the github container registry for others to use.

Types of change

Documentation

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added docs Documentation and website meta Meta topics, e.g. repo organisation and issue management labels Jan 20, 2022
svlandeg
svlandeg reviewed Jan 20, 2022
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be great to have, thanks so much for looking into this Peter!
I only had some small nitpicking comments :-)

website/README.md Outdated Show resolved Hide resolved
website/README.md Outdated Show resolved Hide resolved
website/README.md Outdated Show resolved Hide resolved
pmbaumgartner and others added 4 commits January 20, 2022 08:12
@pmbaumgartner @svlandeg
Update website/README.md
bed4bd9 
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
@pmbaumgartner @svlandeg
Update website/README.md
49a66a0 
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
@pmbaumgartner
clarifying language on docker image
4fbf45d
@pmbaumgartner
fix markdown formatting
05899ad
@svlandeg svlandeg merged commit a690050 into master Jan 20, 2022
svlandeg added a commit that referenced this pull request Jan 20, 2022
@pmbaumgartner @svlandeg
Docker Image for Website Dev (#10098)
fdb314d 
* add docker instructions

* Update website/README.md

Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>

* Update website/README.md

Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>

* clarifying language on docker image

* fix markdown formatting

Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
@svlandeg svlandeg deleted the docs-docker-master branch April 7, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg left review comments

@ines ines ines approved these changes

Assignees
No one assigned
Labels
docs Documentation and website meta Meta topics, e.g. repo organisation and issue management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmbaumgartner @svlandeg @ines