Skip to content

Added integration with Amazon API Gateway + bug fix in _answer_relevance.py #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2023
Merged

Added integration with Amazon API Gateway + bug fix in _answer_relevance.py #327

merged 1 commit into from
Nov 30, 2023

Conversation

brunopistone
Copy link
Contributor

Closed other PR.

  1. Merge with latest changes
  2. Added integration with Amazon API Gateway
  3. fixed bug in _answer_relevance.py, caused by text empty or NaN in the cosine_sim calculation

@shahules786 shahules786 requested a review from jjmachan November 23, 2023 17:11
@jjmachan jjmachan self-assigned this Nov 29, 2023
jjmachan
jjmachan approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@jjmachan jjmachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much @brunopistone for fixing this issue :)

@jjmachan jjmachan merged commit ba3b109 into explodinggradients:main Nov 30, 2023
@jjmachan
Copy link
Member

Hey @brunopistone
Thank you so much for helping us improve ragas with your PR ❤️
Now since it's Christmas and all we wanted to send you a postcard and a couple of stickers as our way of saying thank you for your contribution. If you are interested could you shoot an email at jamesjithin97@gmail.com and I'll tell you more?

Cheers 🙂
Jithin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjmachan jjmachan jjmachan approved these changes

@shahules786 shahules786 shahules786 approved these changes

Assignees

@jjmachan jjmachan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brunopistone @jjmachan @shahules786