Skip to content

Single-hop query testset generation tutorial #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 15, 2025

Conversation

sahusiddharth
Copy link
Collaborator

Contains:

  • Md of tutorials
  • Dummy dataset
  • Changes for the navigations in docs

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Mar 11, 2025
Copy link
Member

@shahules786 shahules786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall Looks great, Just one comment - make the ragas airline dummy data ignore from mkdocs index otherwise it will appear in every search. For example https://ragas--1959.org.readthedocs.build/en/1959/howtos/applications/singlehop_testset_gen/?h=

@shahules786
Copy link
Member

@sahusiddharth Move all files related to the dataset (markdown files such as flight policies to notes repo or huggingface or your personal repos) - modify the tutorial then use it from that source.
We don't keep such data and artifacts along with docs.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Mar 14, 2025
Copy link
Member

@shahules786 shahules786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @sahusiddharth

@shahules786 shahules786 merged commit 2e12744 into explodinggradients:main Mar 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants