Skip to content

r2r integration #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 20, 2025
Merged

r2r integration #1918

merged 8 commits into from
Feb 20, 2025

Conversation

sahusiddharth
Copy link
Collaborator

  • r2r integration
  • fixed spelling mistake in swarm tutorial
  • added @t.runtime_checkable to metric mode

@shahules786 shahules786 marked this pull request as ready for review February 12, 2025 03:21
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Feb 12, 2025
shahules786
shahules786 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@shahules786 shahules786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

jjmachan
jjmachan requested changes Feb 13, 2025
View reviewed changes
Copy link
Member

@jjmachan jjmachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next time we'll start with a design doc first for any integration before moving into the code.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Feb 16, 2025
jjmachan
jjmachan approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@jjmachan jjmachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - just add it to mkdocs navbar too and check the last commit I made (which should fix a merge conflict)

@jjmachan jjmachan merged commit 76e14b0 into explodinggradients:main Feb 20, 2025
21 checks passed
@sahusiddharth sahusiddharth deleted the r2r_integration branch March 10, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjmachan jjmachan jjmachan approved these changes

@shahules786 shahules786 shahules786 approved these changes

Assignees
No one assigned
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sahusiddharth @jjmachan @shahules786